content/browser/download/save_file.h - Issue 1529363006: Introducing SavePackageId and SaveItemId as distinct IdType<...>-based types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/save_file.h

Issue 1529363006: Introducing SavePackageId and SaveItemId as distinct IdType<...>-based types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR feedback from Daniel. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/download/save_file.h

diff --git a/content/browser/download/save_file.h b/content/browser/download/save_file.h

index 84dd3cb3cdc9f3df3df402e6411e8917b1115434..1dc82170ad0ed55f103b3370af0775d9d9393ca2 100644

--- a/content/browser/download/save_file.h

+++ b/content/browser/download/save_file.h

@@ -42,7 +42,7 @@ class SaveFile {

std::string DebugString() const;

// Accessors.

- int save_item_id() const { return info_->save_item_id; }

+ SaveItemId save_item_id() const { return info_->save_item_id; }

int render_process_id() const { return info_->render_process_id; }

int request_id() const { return info_->request_id; }

SaveFileCreateInfo::SaveFileSource save_source() const {

« no previous file with comments | « no previous file | content/browser/download/save_file_manager.h » ('j') | no next file with comments »