tzname check fix

Timezone name check fix

1. Location names with more than one underscores (e.g. Ho_Chi_Minh)
   didn't work because of the way capturing works with repeated patterns
   in RE. It's now supported by changing the RE to capture the whole string
   and splitting on '_' in the next step.

2. Adds support for location names with a hyphen

3. Adds support for timezone ids with three parts (e.g.
   American/Argentina/Buenos_Aires)

4. Adds special handling of 'au', 'es' and 'of' in zone ids. They need to be kept in lowercase. (see the full list at https://en.wikipedia.org/wiki/List_of_tz_database_time_zones )

5. Adds regression tests for all the above and make the existing tests
   more robust against future ICU changes. ICU canonicalizes zone names to
   deprecated names, but it may change. (
   http://bugs.icu-project.org/trac/ticket/12044 )

BUG=364374
LOG=Y

Committed: https://crrev.com/4e18190e690cdee8de2a7d9290ad6b8f45600f4c
Cr-Commit-Position: refs/heads/master@{#33097}

[jungshik at Google, 2015-12-17 20:37:54]

Description was changed from

==========
tzname check fix

BUG=....
==========

to

==========
tzname check fix

BUG=364374
==========

[jungshik at Google, 2015-12-18 22:25:24]

Description was changed from

==========
tzname check fix

BUG=364374
==========

to

==========
Timezone name check fix

1. Location names with more than one underscore (e.g. Ho_Chi_Minh)
   didn't work because of the way capturing works with repeated patterns
   in RE. It's now supported by changing the RE to capture the whole string
   and splitting on '_' in the next step.

2. Adds support for location names can have a hyphen

3. Adds support for timezone ids with three parts (e.g.
   American/Argentina/Buenos_Aires)

4. Adds special handling of 'au', 'es' and 'of' in zone ids. They need to be

5. Adds regression tests for all the above and make the existing tests
   more robust against future ICU changes. ICU canonicalizes zone names to
   deprecated names, but it may change. (
   http://bugs.icu-project.org/trac/ticket/12044 )

BUG=364374
==========

[jungshik at Google, 2015-12-18 22:27:37]

jshin@chromium.org changed reviewers:
+ littledan@chromium.org

[jungshik at Google, 2015-12-18 22:27:37]

Hi, can you take a look? Thanks

[jungshik at Google, 2015-12-18 22:28:01]

Hi Dan, can you take a look? Thanks

[jungshik at Google, 2015-12-18 23:06:59]

jshin@chromium.org changed reviewers:
+ adamk@chromium.org

[jungshik at Google, 2015-12-18 23:06:59]

adamk@chromium.org: Please take a look.

[Dan Ehrenberg, 2015-12-18 23:27:18]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2015-12-18 23:27:19]

lgtm

This looks great, thanks!

[commit-bot: I haz the power, 2015-12-18 23:27:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1529363005/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1529363005/140001

[commit-bot: I haz the power, 2015-12-18 23:29:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-18 23:29:39]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9155)

[adamk, 2016-01-04 18:37:15]

lgtm for OWNERS

Curious about the "es", "of", and "au" special-casing. Is that codified
somewhere? I'm surprised there aren't any places with, say, "de" in them (no
need to hold up landing this).

[jungshik at Google, 2016-01-04 20:07:02]

Description was changed from

==========
Timezone name check fix

1. Location names with more than one underscore (e.g. Ho_Chi_Minh)
   didn't work because of the way capturing works with repeated patterns
   in RE. It's now supported by changing the RE to capture the whole string
   and splitting on '_' in the next step.

2. Adds support for location names can have a hyphen

3. Adds support for timezone ids with three parts (e.g.
   American/Argentina/Buenos_Aires)

4. Adds special handling of 'au', 'es' and 'of' in zone ids. They need to be

5. Adds regression tests for all the above and make the existing tests
   more robust against future ICU changes. ICU canonicalizes zone names to
   deprecated names, but it may change. (
   http://bugs.icu-project.org/trac/ticket/12044 )

BUG=364374
==========

to

==========
Timezone name check fix

1. Location names with more than one underscore (e.g. Ho_Chi_Minh)
   didn't work because of the way capturing works with repeated patterns
   in RE. It's now supported by changing the RE to capture the whole string
   and splitting on '_' in the next step.

2. Adds support for location names can have a hyphen

3. Adds support for timezone ids with three parts (e.g.
   American/Argentina/Buenos_Aires)

4. Adds special handling of 'au', 'es' and 'of' in zone ids. They need to be
kept in lower-case. 

5. Adds regression tests for all the above and make the existing tests
   more robust against future ICU changes. ICU canonicalizes zone names to
   deprecated names, but it may change. (
   http://bugs.icu-project.org/trac/ticket/12044 )

BUG=364374
==========

[jungshik at Google, 2016-01-04 20:57:17]

Description was changed from

==========
Timezone name check fix

1. Location names with more than one underscore (e.g. Ho_Chi_Minh)
   didn't work because of the way capturing works with repeated patterns
   in RE. It's now supported by changing the RE to capture the whole string
   and splitting on '_' in the next step.

2. Adds support for location names can have a hyphen

3. Adds support for timezone ids with three parts (e.g.
   American/Argentina/Buenos_Aires)

4. Adds special handling of 'au', 'es' and 'of' in zone ids. They need to be
kept in lower-case. 

5. Adds regression tests for all the above and make the existing tests
   more robust against future ICU changes. ICU canonicalizes zone names to
   deprecated names, but it may change. (
   http://bugs.icu-project.org/trac/ticket/12044 )

BUG=364374
==========

to

==========
Timezone name check fix

1. Location names with more than one underscores (e.g. Ho_Chi_Minh)
   didn't work because of the way capturing works with repeated patterns
   in RE. It's now supported by changing the RE to capture the whole string
   and splitting on '_' in the next step.

2. Adds support for location names with a hyphen

3. Adds support for timezone ids with three parts (e.g.
   American/Argentina/Buenos_Aires)

4. Adds special handling of 'au', 'es' and 'of' in zone ids. They need to be
kept in lower-case. 

5. Adds regression tests for all the above and make the existing tests
   more robust against future ICU changes. ICU canonicalizes zone names to
   deprecated names, but it may change. (
   http://bugs.icu-project.org/trac/ticket/12044 )

BUG=364374
==========

[jungshik at Google, 2016-01-04 20:59:33]

Description was changed from

==========
Timezone name check fix

1. Location names with more than one underscores (e.g. Ho_Chi_Minh)
   didn't work because of the way capturing works with repeated patterns
   in RE. It's now supported by changing the RE to capture the whole string
   and splitting on '_' in the next step.

2. Adds support for location names with a hyphen

3. Adds support for timezone ids with three parts (e.g.
   American/Argentina/Buenos_Aires)

4. Adds special handling of 'au', 'es' and 'of' in zone ids. They need to be
kept in lower-case. 

5. Adds regression tests for all the above and make the existing tests
   more robust against future ICU changes. ICU canonicalizes zone names to
   deprecated names, but it may change. (
   http://bugs.icu-project.org/trac/ticket/12044 )

BUG=364374
==========

to

==========
Timezone name check fix

1. Location names with more than one underscores (e.g. Ho_Chi_Minh)
   didn't work because of the way capturing works with repeated patterns
   in RE. It's now supported by changing the RE to capture the whole string
   and splitting on '_' in the next step.

2. Adds support for location names with a hyphen

3. Adds support for timezone ids with three parts (e.g.
   American/Argentina/Buenos_Aires)

4. Adds special handling of 'au', 'es' and 'of' in zone ids. They need to be
kept in lowercase. (see the full list at
https://en.wikipedia.org/wiki/List_of_tz_database_time_zones )

5. Adds regression tests for all the above and make the existing tests
   more robust against future ICU changes. ICU canonicalizes zone names to
   deprecated names, but it may change. (
   http://bugs.icu-project.org/trac/ticket/12044 )

BUG=364374
==========

[jungshik at Google, 2016-01-04 21:01:42]

On 2016/01/04 18:37:15, adamk wrote:
> lgtm for OWNERS
> 
> Curious about the "es", "of", and "au" special-casing. Is that codified
> somewhere? I'm surprised there aren't any places with, say, "de" in them (no
> need to hold up landing this).

Thank you for the approval. As for 'de', it's "data-driven". The list at
https://en.wikipedia.org/wiki/List_of_tz_database_time_zones
does not have any timezone with '_de' or '-de'. (I searched for all '[_-][a-z]'
and found 'au' and 'es'. Initially, I only knew of 'of').

[jungshik at Google, 2016-01-04 21:01:56]

The CQ bit was checked by jshin@chromium.org

[commit-bot: I haz the power, 2016-01-04 21:02:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1529363005/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1529363005/140001

[commit-bot: I haz the power, 2016-01-04 21:04:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-04 21:04:52]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9409)

[jungshik at Google, 2016-01-04 21:36:41]

Description was changed from

==========
Timezone name check fix

1. Location names with more than one underscores (e.g. Ho_Chi_Minh)
   didn't work because of the way capturing works with repeated patterns
   in RE. It's now supported by changing the RE to capture the whole string
   and splitting on '_' in the next step.

2. Adds support for location names with a hyphen

3. Adds support for timezone ids with three parts (e.g.
   American/Argentina/Buenos_Aires)

4. Adds special handling of 'au', 'es' and 'of' in zone ids. They need to be
kept in lowercase. (see the full list at
https://en.wikipedia.org/wiki/List_of_tz_database_time_zones )

5. Adds regression tests for all the above and make the existing tests
   more robust against future ICU changes. ICU canonicalizes zone names to
   deprecated names, but it may change. (
   http://bugs.icu-project.org/trac/ticket/12044 )

BUG=364374
==========

to

==========
Timezone name check fix

1. Location names with more than one underscores (e.g. Ho_Chi_Minh)
   didn't work because of the way capturing works with repeated patterns
   in RE. It's now supported by changing the RE to capture the whole string
   and splitting on '_' in the next step.

2. Adds support for location names with a hyphen

3. Adds support for timezone ids with three parts (e.g.
   American/Argentina/Buenos_Aires)

4. Adds special handling of 'au', 'es' and 'of' in zone ids. They need to be
kept in lowercase. (see the full list at
https://en.wikipedia.org/wiki/List_of_tz_database_time_zones )

5. Adds regression tests for all the above and make the existing tests
   more robust against future ICU changes. ICU canonicalizes zone names to
   deprecated names, but it may change. (
   http://bugs.icu-project.org/trac/ticket/12044 )

BUG=364374
LOG=Y
==========

[jungshik at Google, 2016-01-04 21:36:50]

The CQ bit was checked by jshin@chromium.org

[commit-bot: I haz the power, 2016-01-04 21:37:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1529363005/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1529363005/140001

[commit-bot: I haz the power, 2016-01-04 21:47:49]

Description was changed from

==========
Timezone name check fix

1. Location names with more than one underscores (e.g. Ho_Chi_Minh)
   didn't work because of the way capturing works with repeated patterns
   in RE. It's now supported by changing the RE to capture the whole string
   and splitting on '_' in the next step.

2. Adds support for location names with a hyphen

3. Adds support for timezone ids with three parts (e.g.
   American/Argentina/Buenos_Aires)

4. Adds special handling of 'au', 'es' and 'of' in zone ids. They need to be
kept in lowercase. (see the full list at
https://en.wikipedia.org/wiki/List_of_tz_database_time_zones )

5. Adds regression tests for all the above and make the existing tests
   more robust against future ICU changes. ICU canonicalizes zone names to
   deprecated names, but it may change. (
   http://bugs.icu-project.org/trac/ticket/12044 )

BUG=364374
LOG=Y
==========

to

==========
Timezone name check fix

1. Location names with more than one underscores (e.g. Ho_Chi_Minh)
   didn't work because of the way capturing works with repeated patterns
   in RE. It's now supported by changing the RE to capture the whole string
   and splitting on '_' in the next step.

2. Adds support for location names with a hyphen

3. Adds support for timezone ids with three parts (e.g.
   American/Argentina/Buenos_Aires)

4. Adds special handling of 'au', 'es' and 'of' in zone ids. They need to be
kept in lowercase. (see the full list at
https://en.wikipedia.org/wiki/List_of_tz_database_time_zones )

5. Adds regression tests for all the above and make the existing tests
   more robust against future ICU changes. ICU canonicalizes zone names to
   deprecated names, but it may change. (
   http://bugs.icu-project.org/trac/ticket/12044 )

BUG=364374
LOG=Y
==========

[commit-bot: I haz the power, 2016-01-04 21:47:50]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-01-04 21:48:14]

Description was changed from

==========
Timezone name check fix

1. Location names with more than one underscores (e.g. Ho_Chi_Minh)
   didn't work because of the way capturing works with repeated patterns
   in RE. It's now supported by changing the RE to capture the whole string
   and splitting on '_' in the next step.

2. Adds support for location names with a hyphen

3. Adds support for timezone ids with three parts (e.g.
   American/Argentina/Buenos_Aires)

4. Adds special handling of 'au', 'es' and 'of' in zone ids. They need to be
kept in lowercase. (see the full list at
https://en.wikipedia.org/wiki/List_of_tz_database_time_zones )

5. Adds regression tests for all the above and make the existing tests
   more robust against future ICU changes. ICU canonicalizes zone names to
   deprecated names, but it may change. (
   http://bugs.icu-project.org/trac/ticket/12044 )

BUG=364374
LOG=Y
==========

to

==========
Timezone name check fix

1. Location names with more than one underscores (e.g. Ho_Chi_Minh)
   didn't work because of the way capturing works with repeated patterns
   in RE. It's now supported by changing the RE to capture the whole string
   and splitting on '_' in the next step.

2. Adds support for location names with a hyphen

3. Adds support for timezone ids with three parts (e.g.
   American/Argentina/Buenos_Aires)

4. Adds special handling of 'au', 'es' and 'of' in zone ids. They need to be
kept in lowercase. (see the full list at
https://en.wikipedia.org/wiki/List_of_tz_database_time_zones )

5. Adds regression tests for all the above and make the existing tests
   more robust against future ICU changes. ICU canonicalizes zone names to
   deprecated names, but it may change. (
   http://bugs.icu-project.org/trac/ticket/12044 )

BUG=364374
LOG=Y

Committed: https://crrev.com/4e18190e690cdee8de2a7d9290ad6b8f45600f4c
Cr-Commit-Position: refs/heads/master@{#33097}
==========

[commit-bot: I haz the power, 2016-01-04 21:48:15]

Patchset 8 (id:??) landed as
https://crrev.com/4e18190e690cdee8de2a7d9290ad6b8f45600f4c
Cr-Commit-Position: refs/heads/master@{#33097}