Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1529363004: Simplify Node.prototype.baseURI to match the DOM spec (Closed)

Created:
5 years ago by philipj_slow
Modified:
5 years ago
Reviewers:
tkent, fs
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify Node.prototype.baseURI to match the DOM spec https://dom.spec.whatwg.org/#dom-node-baseuri This simplification was made possible by the removal of xml:base in spec and implementation: https://www.w3.org/Bugs/Public/show_bug.cgi?id=20976 https://code.google.com/p/chromium/issues/detail?id=341854 BUG=570679 Committed: https://crrev.com/8f97244621fe1fec0366f66a7e9b6e3361566bf5 Cr-Commit-Position: refs/heads/master@{#365934}

Patch Set 1 #

Messages

Total messages: 18 (9 generated)
philipj_slow
PTAL. This depends on https://codereview.chromium.org/1533653002/ so no dry run, but it passes locally.
5 years ago (2015-12-17 15:23:58 UTC) #5
fs
lgtm
5 years ago (2015-12-17 15:35:47 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529363004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529363004/1
5 years ago (2015-12-17 15:43:21 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-17 17:22:38 UTC) #10
philipj_slow
tkent@, can you double check the already landed https://codereview.chromium.org/1533653002/ and review+cq this as well? Thanks!
5 years ago (2015-12-17 18:32:18 UTC) #11
tkent
lgtm
5 years ago (2015-12-17 22:48:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529363004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529363004/1
5 years ago (2015-12-17 22:50:36 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 23:07:37 UTC) #16
commit-bot: I haz the power
5 years ago (2015-12-17 23:09:17 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f97244621fe1fec0366f66a7e9b6e3361566bf5
Cr-Commit-Position: refs/heads/master@{#365934}

Powered by Google App Engine
This is Rietveld 408576698