Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 152933004: Revert of Reland r245404 "If the destination directory doesn't contain the desired repo, delete it" (Closed)

Created:
6 years, 10 months ago by borenet
Modified:
6 years, 10 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Revert of Reland r245404 ("If the destination directory doesn't contain the desired repo, delete it") (https://codereview.chromium.org/131743022/) Reason for revert: This is still failing third_party DEPS for git-svn... Original issue's description: > Reland r245404 ("If the destination directory doesn't contain the desired repo, delete it") > > BUG= > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=249143 TBR=iannucci@chromium.org,maruel@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=249216

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -269 lines) Patch
M gclient.py View 2 chunks +0 lines, -35 lines 0 comments Download
M gclient_scm.py View 10 chunks +107 lines, -38 lines 0 comments Download
M tests/gclient_scm_test.py View 16 chunks +41 lines, -79 lines 0 comments Download
M tests/gclient_smoketest.py View 6 chunks +6 lines, -117 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
borenet
Created Revert of Reland r245404 ("If the destination directory doesn't contain the desired repo, delete ...
6 years, 10 months ago (2014-02-06 01:13:44 UTC) #1
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-06 01:13:45 UTC) #2
borenet
The CQ bit was checked by borenet@google.com
6 years, 10 months ago (2014-02-06 01:15:59 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-06 01:16:06 UTC) #4
Paweł Hajdan Jr.
The CQ bit was checked by phajdan.jr@chromium.org
6 years, 10 months ago (2014-02-06 01:29:51 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-06 01:30:41 UTC) #6
iannucci
The CQ bit was checked by iannucci@chromium.org
6 years, 10 months ago (2014-02-06 01:58:39 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-06 01:58:51 UTC) #8
ghost stip (do not use)
The CQ bit was checked by stip@chromium.org
6 years, 10 months ago (2014-02-06 02:00:42 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-06 02:00:53 UTC) #10
iannucci
lgtm?
6 years, 10 months ago (2014-02-06 02:01:15 UTC) #11
iannucci
The CQ bit was checked by iannucci@chromium.org
6 years, 10 months ago (2014-02-06 02:01:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/borenet@google.com/152933004/1
6 years, 10 months ago (2014-02-06 02:01:22 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-06 02:03:09 UTC) #14
Message was sent while issue was closed. 
Change committed as 249216

Powered by Google App Engine
This is Rietveld 408576698