Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1529323002: Enable the clang-plugin follow-macro-expansion flag. (Closed)

Created:
5 years ago by Jeffrey Yasskin
Modified:
4 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable the clang-plugin follow-macro-expansion flag. BUG=156590 Committed: https://crrev.com/67fe44028ae6bec0a98cde42e4a7ddbbda5d57e9 Cr-Commit-Position: refs/heads/master@{#372714}

Patch Set 1 #

Patch Set 2 : Sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M build/common.gypi View 1 1 chunk +2 lines, -1 line 0 comments Download
M build/config/clang/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Jeffrey Yasskin
Finally getting around to mailing this.
4 years, 10 months ago (2016-01-28 17:31:54 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529323002/20001
4 years, 10 months ago (2016-01-28 17:32:56 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-28 19:35:38 UTC) #6
Nico
lgtm If this sticks, you can then remove the flag from the plugin code and ...
4 years, 10 months ago (2016-01-30 03:22:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529323002/20001
4 years, 10 months ago (2016-02-01 17:29:36 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-01 19:13:45 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 19:15:21 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/67fe44028ae6bec0a98cde42e4a7ddbbda5d57e9
Cr-Commit-Position: refs/heads/master@{#372714}

Powered by Google App Engine
This is Rietveld 408576698