Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Issue 1529283002: Cleanup: Remove unused SharedMemory ctor. (Closed)

Created:
5 years ago by Lei Zhang
Modified:
5 years ago
Reviewers:
Will Harris
CC:
chromium-reviews, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove unused SharedMemory ctor. BUG=345734 Committed: https://crrev.com/d3ede883000c85863bbbf7265bc4175d57ea3ec1 Cr-Commit-Position: refs/heads/master@{#365776}

Patch Set 1 #

Patch Set 2 : Remove on Windows too? #

Patch Set 3 : Nope, revert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -39 lines) Patch
M base/memory/shared_memory.h View 2 1 chunk +2 lines, -0 lines 0 comments Download
M base/memory/shared_memory_mac.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M base/memory/shared_memory_nacl.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M base/memory/shared_memory_posix.cc View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Lei Zhang
Since we started talking about dead code...
5 years ago (2015-12-16 23:26:48 UTC) #2
Will Harris
On 2015/12/16 23:26:48, Lei Zhang wrote: > Since we started talking about dead code... lgtm; ...
5 years ago (2015-12-17 05:18:56 UTC) #3
Lei Zhang
On 2015/12/17 05:18:56, Will Harris wrote: > On 2015/12/16 23:26:48, Lei Zhang wrote: > > ...
5 years ago (2015-12-17 07:16:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529283002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529283002/40001
5 years ago (2015-12-17 07:17:07 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-17 07:45:48 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-17 07:46:32 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d3ede883000c85863bbbf7265bc4175d57ea3ec1
Cr-Commit-Position: refs/heads/master@{#365776}

Powered by Google App Engine
This is Rietveld 408576698