Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Issue 1529243002: Fix `analyzer_cli` error overrides (#24452). (Closed)

Created:
5 years ago by pquitslund
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix `analyzer_cli` error overrides (#24452). Brings `analyzer_cli` inline with server wrt processing errors configured in `.analysis_options`. Note some added complexity due to interactions with flags that globally escalate warnings/hints to errors. https://github.com/dart-lang/sdk/issues/24452 R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/8887cd69f0f8cb8de36f1ac0986a98c484fdf869

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -51 lines) Patch
M pkg/analyzer_cli/lib/src/analyzer_impl.dart View 4 chunks +45 lines, -15 lines 0 comments Download
M pkg/analyzer_cli/lib/src/error_formatter.dart View 6 chunks +47 lines, -23 lines 0 comments Download
M pkg/analyzer_cli/test/data/options_tests_project/.analysis_options View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/test/data/options_tests_project/test_file.dart View 1 chunk +7 lines, -1 line 0 comments Download
M pkg/analyzer_cli/test/driver_test.dart View 4 chunks +50 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
pquitslund
5 years ago (2015-12-16 19:13:15 UTC) #2
Brian Wilkerson
LGTM
5 years ago (2015-12-16 19:17:05 UTC) #3
pquitslund
5 years ago (2015-12-16 20:44:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8887cd69f0f8cb8de36f1ac0986a98c484fdf869 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698