Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Side by Side Diff: content/browser/resources/media/dump_creator.js

Issue 152923005: Don't overwrite WebRTC AEC dump file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Code review Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 5
6 /** 6 /**
7 * Provides the UI for dump creation. 7 * Provides the UI for dump creation.
8 */ 8 */
9 var DumpCreator = (function() { 9 var DumpCreator = (function() {
10 /** 10 /**
(...skipping 24 matching lines...) Expand all
35 'Enable diagnostic audio recordings.</label></p>' + 35 'Enable diagnostic audio recordings.</label></p>' +
36 '<p>A diagnostic audio recording is used for analyzing audio' + 36 '<p>A diagnostic audio recording is used for analyzing audio' +
37 ' problems. It contains the audio played out from the speaker and' + 37 ' problems. It contains the audio played out from the speaker and' +
38 ' recorded from the microphone and is saved to the local disk.' + 38 ' recorded from the microphone and is saved to the local disk.' +
39 ' Checking this box will enable the recording for an ongoing WebRTC' + 39 ' Checking this box will enable the recording for an ongoing WebRTC' +
40 ' call and for future WebRTC calls. When the box is unchecked or this' + 40 ' call and for future WebRTC calls. When the box is unchecked or this' +
41 ' page is closed, this recording functionality will be disabled for' + 41 ' page is closed, this recording functionality will be disabled for' +
42 ' future WebRTC calls, but an ongoing call will continue to record' + 42 ' future WebRTC calls, but an ongoing call will continue to record' +
43 ' until the call is ended. Only recording in one tab is supported.' + 43 ' until the call is ended. Only recording in one tab is supported.' +
44 ' If several tabs are running WebRTC calls, the resulting file will' + 44 ' If several tabs are running WebRTC calls, the resulting file will' +
45 ' be invalid.</p>'; 45 ' be invalid. To restart the dump, the tab with the call recorded' +
Ami GONE FROM CHROMIUM 2014/02/11 17:37:28 s/recorded/being recorded/
Henrik Grunell 2014/02/12 07:54:05 Done.
46 ' must be closed and recording disabled and enabled again</p>';
46 47
47 content.getElementsByTagName('a')[0].addEventListener( 48 content.getElementsByTagName('a')[0].addEventListener(
48 'click', this.onDownloadData_.bind(this)); 49 'click', this.onDownloadData_.bind(this));
49 content.getElementsByTagName('input')[0].addEventListener( 50 content.getElementsByTagName('input')[0].addEventListener(
50 'click', this.onAecRecordingChanged_.bind(this)); 51 'click', this.onAecRecordingChanged_.bind(this));
51 } 52 }
52 53
53 DumpCreator.prototype = { 54 DumpCreator.prototype = {
54 /** Mark the AEC recording checkbox checked.*/ 55 /** Mark the AEC recording checkbox checked.*/
55 enableAecRecording: function() { 56 enableAecRecording: function() {
(...skipping 28 matching lines...) Expand all
84 var enabled = this.root_.getElementsByTagName('input')[0].checked; 85 var enabled = this.root_.getElementsByTagName('input')[0].checked;
85 if (enabled) { 86 if (enabled) {
86 chrome.send('enableAecRecording'); 87 chrome.send('enableAecRecording');
87 } else { 88 } else {
88 chrome.send('disableAecRecording'); 89 chrome.send('disableAecRecording');
89 } 90 }
90 }, 91 },
91 }; 92 };
92 return DumpCreator; 93 return DumpCreator;
93 })(); 94 })();
OLDNEW
« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698