Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1529173005: Correct return values in CPDF_HintTables::CheckPage() (Closed)

Created:
5 years ago by jun_fang
Modified:
5 years ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com, kai_jing
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : add the braces back for multi-line if statements #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 2 3 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jun_fang
5 years ago (2015-12-18 04:06:25 UTC) #2
jun_fang
5 years ago (2015-12-18 04:06:37 UTC) #3
Lei Zhang
lgtm https://codereview.chromium.org/1529173005/diff/20001/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right): https://codereview.chromium.org/1529173005/diff/20001/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp#newcode4940 core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:4940: pHints)) Please add the braces back for multi-line ...
5 years ago (2015-12-18 07:59:05 UTC) #5
jun_fang
https://codereview.chromium.org/1529173005/diff/20001/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right): https://codereview.chromium.org/1529173005/diff/20001/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp#newcode4940 core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:4940: pHints)) On 2015/12/18 07:59:05, Lei Zhang wrote: > Please ...
5 years ago (2015-12-18 08:05:20 UTC) #6
jun_fang
5 years ago (2015-12-18 08:06:16 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
178086485892c9bb6aa0bf57ee449b33705e71c0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698