Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1529113002: [es6] Consistently use %_GetSuperConstructor to implement super calls. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Consistently use %_GetSuperConstructor to implement super calls. Following up on https://crrev.com/1517243002, we use the %_GetSuperConstructor consistently for all super calls now (inlining the intrinsic code in fullcodegen). R=mstarzinger@chromium.org BUG=v8:3330 LOG=n Committed: https://crrev.com/fe88e5479286ecba10e181bc65325355345c8c55 Cr-Commit-Position: refs/heads/master@{#32890}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -29 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +9 lines, -2 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +9 lines, -2 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +9 lines, -2 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +9 lines, -2 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +9 lines, -2 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Benedikt Meurer
5 years ago (2015-12-16 09:50:54 UTC) #1
Benedikt Meurer
Hey Michi, This is follow up cleanup for super calls. Please take a look. Thanks, ...
5 years ago (2015-12-16 09:52:30 UTC) #2
Michael Starzinger
LGTM. https://codereview.chromium.org/1529113002/diff/1/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (right): https://codereview.chromium.org/1529113002/diff/1/src/compiler/ast-graph-builder.cc#newcode2504 src/compiler/ast-graph-builder.cc:2504: // Prepare the callee to the super call. ...
5 years ago (2015-12-16 10:48:47 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/1529113002/diff/1/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (right): https://codereview.chromium.org/1529113002/diff/1/src/compiler/ast-graph-builder.cc#newcode2504 src/compiler/ast-graph-builder.cc:2504: // Prepare the callee to the super call. The ...
5 years ago (2015-12-16 10:49:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529113002/20001
5 years ago (2015-12-16 10:49:59 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-16 11:08:04 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-16 11:08:13 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fe88e5479286ecba10e181bc65325355345c8c55
Cr-Commit-Position: refs/heads/master@{#32890}

Powered by Google App Engine
This is Rietveld 408576698