Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: tools/full-coverage.dart

Issue 1529063006: - Implement Platform.packageRoot and Platform.packageConfig based (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/bin/builtin.dart ('K') | « tests/standalone/io/platform_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/full-coverage.dart
diff --git a/tools/full-coverage.dart b/tools/full-coverage.dart
index 29635743f0e8b026faf88713aa895e139e147373..d7ff76f005668bd81aec804d45b25131e9a60723 100644
--- a/tools/full-coverage.dart
+++ b/tools/full-coverage.dart
@@ -462,9 +462,11 @@ parseArgs(List<String> arguments) {
env.pkgRoot = args["package-root"];
if (env.pkgRoot != null) {
- env.pkgRoot = absolute(normalize(args["package-root"]));
- if (!FileSystemEntity.isDirectorySync(env.pkgRoot)) {
- fail("Provided package root '${args["package-root"]}' is not directory.");
+ var pkgRootUri = Uri.parse(env.pkgRoot);
+ if (pkgRootUri.scheme == "file") {
+ if (!FileSystemEntity.isDirectorySync(pkgRootUri.toFilePath())) {
+ fail("Provided package root '${args["package-root"]}' is not directory.");
+ }
}
} else {
env.pkgRoot = Platform.packageRoot;
« runtime/bin/builtin.dart ('K') | « tests/standalone/io/platform_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698