Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1118)

Unified Diff: media/mojo/services/mojo_media_client.cc

Issue 1529063004: Pass MojoMediaClient instance to MojoMediaApplication constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/mojo/services/mojo_media_client.cc
diff --git a/media/mojo/services/mojo_media_client.cc b/media/mojo/services/mojo_media_client.cc
index 3d05f1b7925e37e0f8479599c38246f8a65c20f2..ba10760d577a2ad1aac00e86f43211f5db083826 100644
--- a/media/mojo/services/mojo_media_client.cc
+++ b/media/mojo/services/mojo_media_client.cc
@@ -34,36 +34,34 @@ namespace internal {
extern scoped_ptr<PlatformMojoMediaClient> CreatePlatformMojoMediaClient();
} // namespace internal
-static base::LazyInstance<MojoMediaClient>::Leaky g_mojo_media_client =
- LAZY_INSTANCE_INITIALIZER;
-
// static
-MojoMediaClient* MojoMediaClient::Get() {
- return g_mojo_media_client.Pointer();
+scoped_ptr<MojoMediaClient> MojoMediaClient::Create() {
+ return make_scoped_ptr(
+ new MojoMediaClient(internal::CreatePlatformMojoMediaClient()));
}
scoped_ptr<RendererFactory> MojoMediaClient::CreateRendererFactory(
const scoped_refptr<MediaLog>& media_log) {
- return mojo_media_client_->CreateRendererFactory(media_log);
+ return impl_->CreateRendererFactory(media_log);
}
scoped_refptr<AudioRendererSink> MojoMediaClient::CreateAudioRendererSink() {
- return mojo_media_client_->CreateAudioRendererSink();
+ return impl_->CreateAudioRendererSink();
}
scoped_ptr<VideoRendererSink> MojoMediaClient::CreateVideoRendererSink(
const scoped_refptr<base::SingleThreadTaskRunner>& task_runner) {
- return mojo_media_client_->CreateVideoRendererSink(task_runner);
+ return impl_->CreateVideoRendererSink(task_runner);
}
scoped_ptr<CdmFactory> MojoMediaClient::CreateCdmFactory(
mojo::ServiceProvider* service_provider) {
- return mojo_media_client_->CreateCdmFactory(service_provider);
+ return impl_->CreateCdmFactory(service_provider);
}
-MojoMediaClient::MojoMediaClient()
- : mojo_media_client_(internal::CreatePlatformMojoMediaClient()) {
- DCHECK(mojo_media_client_);
+MojoMediaClient::MojoMediaClient(scoped_ptr<PlatformMojoMediaClient> impl)
+ : impl_(impl.Pass()) {
+ DCHECK(impl_);
}
MojoMediaClient::~MojoMediaClient() {

Powered by Google App Engine
This is Rietveld 408576698