Pass MojoMediaClient instance to MojoMediaApplication constructor.

media/mojo/services/mojo_media_application.cc

Index: media/mojo/services/mojo_media_application.cc
diff --git a/media/mojo/services/mojo_media_application.cc b/media/mojo/services/mojo_media_application.cc
index e568514c07837833bb5d91c52accd01e2adbe770..2f7b10f0e2618b4351b5d6c9d10c0e536bc8c824 100644
--- a/media/mojo/services/mojo_media_application.cc
+++ b/media/mojo/services/mojo_media_application.cc
@@ -6,6 +6,7 @@
 
 #include "base/logging.h"
 #include "media/base/media_log.h"
+#include "media/mojo/services/mojo_media_client.h"
 #include "media/mojo/services/service_factory_impl.h"
 #include "mojo/application/public/cpp/application_connection.h"
 #include "mojo/application/public/cpp/application_impl.h"
@@ -17,12 +18,16 @@ scoped_ptr<mojo::ApplicationDelegate> MojoMediaApplication::CreateApp() {
   // In all existing use cases we don't need to initialize logging when using
   // CreateApp() to create the application. We can pass |enable_logging| in
   // CreateApp() if this isn't the case any more in the future.
-  return scoped_ptr<mojo::ApplicationDelegate>(new MojoMediaApplication(false));
+  return scoped_ptr<mojo::ApplicationDelegate>(
+      new MojoMediaApplication(false, MojoMediaClient::Create()));
 }
 
 // TODO(xhwang): Hook up MediaLog when possible.
-MojoMediaApplication::MojoMediaApplication(bool enable_logging)
+MojoMediaApplication::MojoMediaApplication(
+    bool enable_logging,
+    scoped_ptr<MojoMediaClient> media_client)
     : enable_logging_(enable_logging),
+      media_client_(media_client.Pass()),

[xhwang, 2015/12/16 21:30:31]

replace Pass() with std::move

[alokp, 2015/12/16 22:57:29]

fancy! Done.

       app_impl_(nullptr),
       media_log_(new MediaLog()) {}
 
@@ -53,7 +58,8 @@ void MojoMediaApplication::Create(
   // The created object is owned by the pipe.
   new ServiceFactoryImpl(request.Pass(), connection->GetServiceProvider(),
                          media_log_,
-                         app_impl_->app_lifetime_helper()->CreateAppRefCount());
+                         app_impl_->app_lifetime_helper()->CreateAppRefCount(),
+                         media_client_.get());

[xhwang, 2015/12/16 21:30:31]

ServiceFactoryImpl is owned by the pipe but media_client_ is owned by the
MojoMediaApplication. How does the lifetime work here to ensure this pointer is
always valid?

Probably add a comment that since ServiceFactoryImpl owns a ref to the
AppRefCount, this is safe etc.

[alokp, 2015/12/16 22:57:29]

A service cannot outlive the host application, right?

[xhwang, 2015/12/16 23:43:36]

Acknowledged.

 }
 
 }  // namespace media