Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 152903005: don't initialize the default Skia tracer if one has already been provided (Closed)

Created:
6 years, 10 months ago by humper
Modified:
6 years, 10 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

don't initialize the default Skia tracer if one has already been provided BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13284

Patch Set 1 #

Patch Set 2 : "initialize" is a hard word to spell #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M src/utils/SkEventTracer.cpp View 1 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
humper
PTAL
6 years, 10 months ago (2014-02-03 18:39:28 UTC) #1
bsalomon
lgtm
6 years, 10 months ago (2014-02-03 18:40:34 UTC) #2
humper
The CQ bit was checked by humper@google.com
6 years, 10 months ago (2014-02-03 18:51:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/152903005/30001
6 years, 10 months ago (2014-02-03 18:51:25 UTC) #4
commit-bot: I haz the power
Change committed as 13284
6 years, 10 months ago (2014-02-03 19:36:25 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 19:36:28 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 19:37:27 UTC) #7
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698