Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 152903004: Clarify what code handles 'An end tag whose tag name is "script"' (Closed)

Created:
6 years, 10 months ago by philipj_slow
Modified:
6 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Visibility:
Public.

Description

Clarify what code handles 'An end tag whose tag name is "script"' The "running a script" algorithm was renamed to "prepare a script" in 2011 <http://html5.org/r/5855>;, but HTMLScriptRunner::runScript doesn't actually correspond to that algorithm, so remove the comment. BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166345

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M Source/core/html/parser/HTMLScriptRunner.cpp View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
philipj_slow
PTAL, I found this bit of stale documentation when trying to add the "await a ...
6 years, 10 months ago (2014-02-03 17:45:16 UTC) #1
tkent
lgtm
6 years, 10 months ago (2014-02-04 00:45:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/152903004/1
6 years, 10 months ago (2014-02-04 00:46:11 UTC) #3
commit-bot: I haz the power
Change committed as 166345
6 years, 10 months ago (2014-02-04 00:46:22 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:46:23 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:46:27 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:46:28 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:46:31 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-04 00:48:51 UTC) #9
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698