Issue 152903002: Move m_overridesItemAfter member from LiveNodeListBase to HTMLCollection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 152903002: Move m_overridesItemAfter member from LiveNodeListBase to HTMLCollection (Closed)

Created:
6 years, 10 months ago by Inactive

Modified:
6 years, 10 months ago

Reviewers:
esprehn, adamk

CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Move m_overridesItemAfter member from LiveNodeListBase to HTMLCollection Move m_overridesItemAfter member from LiveNodeListBase to HTMLCollection as LiveNodeList never override itemAfter() and this is only useful for HTMLCollection subclasses. Also introduce a new canTraverseBackward() method to HTMLCollection and LiveNodeList() that is used by CollectionIndexCache. This method is inlined and returns true unconditionally for LiveNodeList which lets the compiler simplify the branching for the LiveNodeList specialization of CollectionIndexCache. This results in a 2-3% improvement on the following performance test: PerformanceTests/Bindings/node-list-access.html This patch is based the following WebKit revision by <antti@apple.com>;: http://trac.webkit.org/changeset/158774 R=esprehn, adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166351

Patch Set 1 #

Patch Set 2 : No change #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -19 lines)			Patch
M	Source/core/dom/LiveNodeList.h	View	5 chunks	+3 lines, -13 lines	0 comments	Download
M	Source/core/html/CollectionIndexCache.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/html/HTMLCollection.h	View	3 chunks	+10 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLCollection.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/152903002/30001

6 years, 10 months ago (2014-02-04 01:19:18 UTC) #4

Message was sent while issue was closed.

Change committed as 166351

Expand Messages | Collapse Messages