Quirks Client for downloading and providing display profiles

chrome/browser/chromeos/display/quirks_client_delegate_impl.h

Index: chrome/browser/chromeos/display/quirks_client_delegate_impl.h
diff --git a/chrome/browser/chromeos/display/quirks_client_delegate_impl.h b/chrome/browser/chromeos/display/quirks_client_delegate_impl.h
new file mode 100644
index 0000000000000000000000000000000000000000..e5358a199c564ea486ed0a92486ee8075f1f5c02
--- /dev/null
+++ b/chrome/browser/chromeos/display/quirks_client_delegate_impl.h
@@ -0,0 +1,26 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.

[oshima, 2016/01/28 20:16:30]

2016

same for other files

[Greg Levin, 2016/02/01 23:17:43]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_DISPLAY_QUIRKS_CLIENT_DELEGATE_IMPL_H_
+#define CHROME_BROWSER_CHROMEOS_DISPLAY_QUIRKS_CLIENT_DELEGATE_IMPL_H_
+
+#include "components/quirks_client/quirks_client.h"
+
+namespace quirks_client {
+
+// Working implementation of QuirksClientManager::Delegate for access to chrome-
+// restricted parts.
+class QuirksClientDelegateImpl : public QuirksClientManager::Delegate {
+ public:
+  ~QuirksClientDelegateImpl() override {}

[oshima, 2016/01/28 20:16:30]

= default;

[Greg Levin, 2016/02/01 23:17:43]

Done.

+
+  // QuirksClientManager::Delegate implementation.
+  std::string api_key_quirks() override;

[oshima, 2016/01/28 20:16:30]

GetApiKeyQuirks()

[Greg Levin, 2016/02/01 23:17:43]

Done.

+  base::FilePath GetDisplayProfileDirectory() override;
+  int GetDaysSinceOobe() override;

[oshima, 2016/01/28 20:16:30]

can these be const? (just a q)

[Greg Levin, 2016/02/01 23:17:43]

They can be (and now are).  Is this preferable, even when the class has no
members to alter?

[oshima, 2016/02/02 18:29:13]

Yes, in general (having member or not is implementation details from client
point of view)
unless you're sure that it will never have a state in the future.

+};

[oshima, 2016/01/28 20:16:30]

private:
DISALLOW_COPY_AND_ASSIGN

[Greg Levin, 2016/02/01 23:17:43]

Done.

+
+}  // namespace quirks_client
+
+#endif  // CHROME_BROWSER_CHROMEOS_DISPLAY_QUIRKS_CLIENT_DELEGATE_IMPL_H_