Quirks Client for downloading and providing display profiles

chrome/browser/chromeos/display/quirks_manager_delegate_impl.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/display/quirks_manager_delegate_impl.h"
+
+#include "base/path_service.h"
+#include "base/sys_info.h"
+#include "base/task_runner_util.h"
+#include "base/threading/thread_restrictions.h"
+#include "chrome/browser/chromeos/login/startup_utils.h"
+#include "chrome/common/chrome_paths.h"
+#include "chromeos/chromeos_paths.h"
+#include "content/public/browser/browser_thread.h"
+#include "google_apis/google_api_keys.h"
+
+namespace {
+
+int GetDaysSinceOobeOnBlockingPool() {
+  base::ThreadRestrictions::AssertIOAllowed();
+  return chromeos::StartupUtils::GetTimeSinceOobeFlagFileCreation().InDays();
+}
+
+}  // namespace
+
+namespace quirks {
+
+std::string QuirksManagerDelegateImpl::GetApiKey() const {
+  return google_apis::GetAPIKey();
+}
+
+base::FilePath QuirksManagerDelegateImpl::GetBuiltInDisplayProfileDirectory()
+    const {
+  base::FilePath path;
+  DCHECK(
+      PathService::Get(chromeos::DIR_DEVICE_COLOR_CALIBRATION_PROFILES, &path));

[stevenjb, 2016/03/21 17:43:59]

This will fail on a release build since DCHECK() is optimized out entirely. Use
if (!PathService::Get(...)) LOG(ERROR) instead.

[Greg Levin, 2016/03/21 21:12:45]

Ugh, thanks.  Don't know what brain fart caused me to put a DCHECK here >_<

+  return path;
+}
+
+// On chrome device, returns /var/cache/display_profiles.
+// On Linux desktop, returns {DIR_USER_DATA}/display_profiles.
+base::FilePath QuirksManagerDelegateImpl::GetDownloadDisplayProfileDirectory()
+    const {
+  base::FilePath directory;
+  if (base::SysInfo::IsRunningOnChromeOS()) {
+    PathService::Get(chromeos::DIR_DEVICE_DISPLAY_PROFILES, &directory);
+  } else {
+    PathService::Get(chrome::DIR_USER_DATA, &directory);
+    directory = directory.Append("display_profiles");

[stevenjb, 2016/03/21 17:43:59]

"display_profiles" should be defined as a const in the anon namespace at the top
of this file.

[Greg Levin, 2016/03/21 21:12:45]

Done.

+  }
+  return directory;
+}
+
+void QuirksManagerDelegateImpl::GetDaysSinceOobe(
+    QuirksManager::DaysSinceOobeCallback callback) const {
+  base::PostTaskAndReplyWithResult(
+      content::BrowserThread::GetBlockingPool(), FROM_HERE,
+      base::Bind(&GetDaysSinceOobeOnBlockingPool), callback);
+}
+
+}  // namespace quirks