components/quirks_client.gypi - Issue 1528963002: Quirks Client for downloading and providing display profiles

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/quirks_client.gypi

Issue 1528963002: Quirks Client for downloading and providing display profiles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First round of review fixes, separate QCManager into separate file Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 {

	6 'targets': [

	7 {

	8 # GN version: //components/quirks_client

	9 'target_name': 'quirks_client',

	10 'type': 'static_library',

	11 'dependencies': [

	12 '../base/base.gyp:base',

	13 '../base/base.gyp:base_prefs',
	oshima 2016/02/02 18:29:13 looks like you need dependency to net and that's p looks like you need dependency to net and that's probably why you were getting linkage errors. Greg Levin 2016/02/09 18:56:38 There are still some build issues that we'll need Show quoted text On 2016/02/02 18:29:13, oshima wrote: > looks like you need dependency to net and that's probably why you were getting > linkage errors. There are still some build issues that we'll need to work out in the next patch.
	14 ],

	15 'include_dirs': [

	16 '..',

	17 ],

	18 'defines': [

	19 'QUIRKS_CLIENT_IMPLEMENTATION',

	20 ],

	21 'sources': [

	22 # Note: sources list duplicated in GN build.

	23 'quirks_client/pref_names.cc',

	24 'quirks_client/pref_names.h',

	25 'quirks_client/quirks_client.cc',

	26 'quirks_client/quirks_client.h',

	27 'quirks_client/quirks_client_export.h',

	28 'quirks_client/quirks_client_manager.cc',

	29 'quirks_client/quirks_client_manager.h',

	30 'quirks_client/switches.cc',

	31 'quirks_client/switches.h',

	32 ],

	33 },

	34 ],

	35 }

OLD	NEW

« chrome/browser/chromeos/chrome_browser_main_chromeos.cc ('K') | « components/components.gyp ('k') | components/quirks_client/BUILD.gn » ('j') | components/quirks_client/OWNERS » ('J')