runtime/vm/intrinsifier_ia32.cc - Issue 1528873002: VM: Use read-only handle Object::dynamic_type() where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intrinsifier_ia32.cc

Issue 1528873002: VM: Use read-only handle Object::dynamic_type() where possible. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intrinsifier_ia32.cc

diff --git a/runtime/vm/intrinsifier_ia32.cc b/runtime/vm/intrinsifier_ia32.cc

index 577775ea72bc5736241ab6395ac1605173f50bbd..61620c870ebd17441b786c72e7b3561e40476ddc 100644

--- a/runtime/vm/intrinsifier_ia32.cc

+++ b/runtime/vm/intrinsifier_ia32.cc

@@ -77,7 +77,7 @@ void Intrinsifier::ObjectArraySetIndexed(Assembler* assembler) {

// Check if it's dynamic.

// Get type at index 0.

__ movl(EAX, FieldAddress(EBX, TypeArguments::type_at_offset(0)));

- __ CompareObject(EAX, Type::ZoneHandle(Type::DynamicType()));

+ __ CompareObject(EAX, Object::dynamic_type());

__ j(EQUAL, &checked_ok, Assembler::kNearJump);

// Check for int and num.

__ testl(EDI, Immediate(kSmiTagMask)); // Value is Smi?

« no previous file with comments | « runtime/vm/flow_graph_type_propagator.cc ('k') | runtime/vm/parser.h » ('j') | no next file with comments »