Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 1528863004: Add owners file to GN bootstrap. (Closed)

Created:
5 years ago by brettw
Modified:
5 years ago
Reviewers:
Dirk Pranke, tfarina
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add owners file to GN bootstrap. Add comment to the top of the script to clarify support and to suggest the type of thing that usually goes wrong. Committed: https://crrev.com/484f322506039ab63ddfbcf3820932f561e5a0f9 Cr-Commit-Position: refs/heads/master@{#365290}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, --1 lines) Patch
A + tools/gn/bootstrap/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/gn/bootstrap/bootstrap.py View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
brettw
5 years ago (2015-12-15 17:58:28 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528863004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528863004/1
5 years ago (2015-12-15 18:00:07 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528863004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528863004/20001
5 years ago (2015-12-15 18:03:53 UTC) #6
Dirk Pranke
lgtm
5 years ago (2015-12-15 18:11:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528863004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528863004/20001
5 years ago (2015-12-15 18:16:59 UTC) #10
tfarina
lgtm
5 years ago (2015-12-15 18:18:52 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-15 18:26:40 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-15 18:27:36 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/484f322506039ab63ddfbcf3820932f561e5a0f9
Cr-Commit-Position: refs/heads/master@{#365290}

Powered by Google App Engine
This is Rietveld 408576698