Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 1528853002: [interpreter] Use interpreter on all function literals. (Closed)

Created:
5 years ago by Michael Starzinger
Modified:
5 years ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Use interpreter on all function literals. This fixes a path in the compilation pipeline that side-stepped the interpreter when a function literal was eagerly compiled. This caused the interpreter to miss some test coverage. R=rmcilroy@chromium.org Committed: https://crrev.com/1e385a832a0822568bc2827f0a18c9660e202345 Cr-Commit-Position: refs/heads/master@{#32867}

Patch Set 1 #

Patch Set 2 : Skip more. #

Total comments: 2

Patch Set 3 : Addressed comment. #

Patch Set 4 : One more skip. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
M src/compiler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M test/test262/test262.status View 1 2 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Michael Starzinger
5 years ago (2015-12-15 10:51:43 UTC) #1
rmcilroy
Thanks for doing this! LGTM https://codereview.chromium.org/1528853002/diff/20001/test/test262/test262.status File test/test262/test262.status (right): https://codereview.chromium.org/1528853002/diff/20001/test/test262/test262.status#newcode636 test/test262/test262.status:636: 'built-ins/GeneratorFunction/invoked-as-function-single-argument': [SKIP], (optional) You ...
5 years ago (2015-12-15 11:06:11 UTC) #2
rmcilroy
Thanks for doing this! LGTM
5 years ago (2015-12-15 11:06:14 UTC) #3
Michael Starzinger
Thanks. Landing. https://codereview.chromium.org/1528853002/diff/20001/test/test262/test262.status File test/test262/test262.status (right): https://codereview.chromium.org/1528853002/diff/20001/test/test262/test262.status#newcode636 test/test262/test262.status:636: 'built-ins/GeneratorFunction/invoked-as-function-single-argument': [SKIP], On 2015/12/15 11:06:11, rmcilroy wrote: ...
5 years ago (2015-12-15 11:36:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528853002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528853002/60001
5 years ago (2015-12-15 14:11:47 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-15 14:12:39 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-15 14:13:01 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/1e385a832a0822568bc2827f0a18c9660e202345
Cr-Commit-Position: refs/heads/master@{#32867}

Powered by Google App Engine
This is Rietveld 408576698