Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1528843002: [regexp] remove some dead code. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] remove some dead code. credits to gcov. Committed: https://crrev.com/a51580067036f25c51d1d04b37e764123febe9f6 Cr-Commit-Position: refs/heads/master@{#32868}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M src/regexp/regexp-macro-assembler.h View 1 chunk +2 lines, -7 lines 0 comments Download
M src/regexp/regexp-macro-assembler-tracer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/regexp/regexp-macro-assembler-tracer.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1522883002 Patch 1

Messages

Total messages: 8 (3 generated)
Yang
5 years ago (2015-12-15 10:02:15 UTC) #2
Camillo Bruni
lgtm
5 years ago (2015-12-15 14:05:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528843002/1
5 years ago (2015-12-15 14:17:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 14:48:08 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-15 14:49:05 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a51580067036f25c51d1d04b37e764123febe9f6
Cr-Commit-Position: refs/heads/master@{#32868}

Powered by Google App Engine
This is Rietveld 408576698