Issue 152883004: Fix potential crash in WebEmbeddedWorkerImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 152883004: Fix potential crash in WebEmbeddedWorkerImpl (Closed)

Created:
6 years, 10 months ago by kinuko

Modified:
6 years, 10 months ago

Reviewers:
adamk

CC:
blink-reviews, alecflett

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Fix potential crash in WebEmbeddedWorkerImpl Calling Client::workerContextFailedToStart() could immediately delte WebEmbeddedWorkerImpl, so it shouldn't touch its member variable after that. (Without this fix the SW layout test could crash after browser-side patch lands in chromium) BUG=285976 TEST=virtual/serviceworker/http/tests/serviceworker/registration.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166731