Source/modules/webdatabase/QuotaTracker.cpp - Issue 152883002: (Concept patch) Simplify WTF::HashTable::add() return value for size and performance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webdatabase/QuotaTracker.cpp

Issue 152883002: (Concept patch) Simplify WTF::HashTable::add() return value for size and performance (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/dom/custom/CustomElementUpgradeCandidateMap.cpp ('K') | « Source/core/rendering/RenderObject.cpp ('k') | Source/modules/webdatabase/SQLTransactionCoordinator.cpp » ('j') | Source/wtf/HashTable.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webdatabase/QuotaTracker.cpp

diff --git a/Source/modules/webdatabase/QuotaTracker.cpp b/Source/modules/webdatabase/QuotaTracker.cpp

index e6fa44b3b59692a9570c02dd82d8ab796b2dc3f4..35190d63ed459fdecdd8bd49a69d02292cb11e39 100644

--- a/Source/modules/webdatabase/QuotaTracker.cpp

+++ b/Source/modules/webdatabase/QuotaTracker.cpp

@@ -70,7 +70,7 @@ void QuotaTracker::updateDatabaseSize(

unsigned long long databaseSize)

{

MutexLocker lockData(m_dataGuard);

- HashMap<String, SizeMap>::iterator it = m_databaseSizes.add(originIdentifier, SizeMap()).iterator;

+ HashMap<String, SizeMap>::ValueType* it = m_databaseSizes.add(originIdentifier, SizeMap()).iterator;

it->value.set(databaseName, databaseSize);

}