Source/core/rendering/RenderLayer.cpp - Issue 152883002: (Concept patch) Simplify WTF::HashTable::add() return value for size and performance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderLayer.cpp

Issue 152883002: (Concept patch) Simplify WTF::HashTable::add() return value for size and performance (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/dom/custom/CustomElementUpgradeCandidateMap.cpp ('K') | « Source/core/rendering/RenderBlockLineLayout.cpp ('k') | Source/core/rendering/RenderObject.cpp » ('j') | Source/wtf/HashTable.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderLayer.cpp

diff --git a/Source/core/rendering/RenderLayer.cpp b/Source/core/rendering/RenderLayer.cpp

index bf2f39420dadded07e16b9b51166dcd65e77b2a9..69822287fe8c6471f3455338e8852ef88003db41 100644

--- a/Source/core/rendering/RenderLayer.cpp

+++ b/Source/core/rendering/RenderLayer.cpp

@@ -3891,9 +3891,11 @@ void RenderLayer::addLayerHitTestRects(LayerHitTestRects& rects) const

rects.set(this, rect);

if (const RenderLayer* parentLayer = parent()) {

LayerHitTestRects::iterator iter = rects.find(parentLayer);

- if (iter == rects.end())

- iter = rects.add(parentLayer, Vector<LayoutRect>()).iterator;

- iter->value.append(boundingBox(parentLayer));

+ if (iter == rects.end()) {

+ rects.add(parentLayer, Vector<LayoutRect>()).iterator->value.append(boundingBox(parentLayer));

+ } else {

+ iter->value.append(boundingBox(parentLayer));

+ }

}

} else {

rect.append(localBoundingBox());