Source/core/inspector/TraceEventDispatcher.cpp - Issue 152883002: (Concept patch) Simplify WTF::HashTable::add() return value for size and performance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/TraceEventDispatcher.cpp

Issue 152883002: (Concept patch) Simplify WTF::HashTable::add() return value for size and performance (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/dom/custom/CustomElementUpgradeCandidateMap.cpp ('K') | « Source/core/inspector/InspectorDebuggerAgent.cpp ('k') | Source/core/page/EventHandler.cpp » ('j') | Source/wtf/HashTable.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/TraceEventDispatcher.cpp

diff --git a/Source/core/inspector/TraceEventDispatcher.cpp b/Source/core/inspector/TraceEventDispatcher.cpp

index bdfbea6fe58dff18b19af8ffc4a6468386c99c35..ef8ecb9a9e7b959e0595c1e33d36b04fe8224fba 100644

--- a/Source/core/inspector/TraceEventDispatcher.cpp

+++ b/Source/core/inspector/TraceEventDispatcher.cpp

@@ -106,8 +106,9 @@ void TraceEventDispatcher::innerAddListener(const char* name, char phase, TraceE

client->setTraceEventCallback(dispatchEventOnAnyThread);

HandlersMap::iterator it = m_handlers.find(std::make_pair(name, phase));

if (it == m_handlers.end())

- it = m_handlers.add(std::make_pair(name, phase), Vector<BoundTraceEventHandler>()).iterator;

- it->value.append(BoundTraceEventHandler(instance, method));

+ m_handlers.add(std::make_pair(name, phase), Vector<BoundTraceEventHandler>()).iterator->value.append(BoundTraceEventHandler(instance, method));

+ else

+ it->value.append(BoundTraceEventHandler(instance, method));

}

void TraceEventDispatcher::removeAllListeners(TraceEventTargetBase* instance, InspectorClient* client)