Source/core/inspector/InspectorDOMAgent.cpp - Issue 152883002: (Concept patch) Simplify WTF::HashTable::add() return value for size and performance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorDOMAgent.cpp

Issue 152883002: (Concept patch) Simplify WTF::HashTable::add() return value for size and performance (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/dom/custom/CustomElementUpgradeCandidateMap.cpp ('K') | « Source/core/inspector/DOMPatchSupport.cpp ('k') | Source/core/inspector/InspectorDebuggerAgent.cpp » ('j') | Source/wtf/HashTable.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorDOMAgent.cpp

diff --git a/Source/core/inspector/InspectorDOMAgent.cpp b/Source/core/inspector/InspectorDOMAgent.cpp

index dd4a120d51caf0dd74a57af285278b6e8c432f60..179e59040ce11cdc2c5e081d5947e8d04dd76c8d 100755

--- a/Source/core/inspector/InspectorDOMAgent.cpp

+++ b/Source/core/inspector/InspectorDOMAgent.cpp

@@ -1025,12 +1025,12 @@ void InspectorDOMAgent::performSearch(ErrorString*, const String& whitespaceTrim

}

*searchId = IdentifiersFactory::createIdentifier();

- SearchResults::iterator resultsIt = m_searchResults.add(*searchId, Vector<RefPtr<Node> >()).iterator;

+ Vector<RefPtr<Node> >* resultsIt = &m_searchResults.add(*searchId, Vector<RefPtr<Node> >()).iterator->value;

for (ListHashSet<Node*>::iterator it = resultCollector.begin(); it != resultCollector.end(); ++it)

- resultsIt->value.append(*it);

+ resultsIt->append(*it);

- *resultCount = resultsIt->value.size();

+ *resultCount = resultsIt->size();

}

void InspectorDOMAgent::getSearchResults(ErrorString* errorString, const String& searchId, int fromIndex, int toIndex, RefPtr<TypeBuilder::Array<int> >& nodeIds)