(Concept patch) Simplify WTF::HashTable::add() return value for size and performance

Source/core/animation/KeyframeEffectModel.cpp

Index: Source/core/animation/KeyframeEffectModel.cpp
diff --git a/Source/core/animation/KeyframeEffectModel.cpp b/Source/core/animation/KeyframeEffectModel.cpp
index 4c3697248a95dd55f7923bd25e3d51bd3a3d5222..705ce865460cbcb31243ed49d5838b134b8e8b9a 100644
--- a/Source/core/animation/KeyframeEffectModel.cpp
+++ b/Source/core/animation/KeyframeEffectModel.cpp
@@ -250,10 +250,12 @@ void KeyframeEffectModel::ensureKeyframeGroups() const
             if (groupIter == m_keyframeGroups->end()) {
                 KeyframeGroupMap::AddResult result = m_keyframeGroups->add(property, adoptPtr(new PropertySpecificKeyframeGroup));
                 ASSERT(result.isNewEntry);
-                groupIter = result.iterator;
-            }
+                result.iterator->value->appendKeyframe(adoptPtr(
+                new PropertySpecificKeyframe(keyframe->offset(), keyframe->propertyValue(property), keyframe->composite())));

[Erik Corry, 2014/02/04 14:27:15]

Funny indentation, and there's a chunk of repeated code between here and the
else clause.

+            } else {
             groupIter->value->appendKeyframe(adoptPtr(
                 new PropertySpecificKeyframe(keyframe->offset(), keyframe->propertyValue(property), keyframe->composite())));
+            }
         }
     }