(Concept patch) Simplify WTF::HashTable::add() return value for size and performance

Source/core/dom/custom/CustomElementUpgradeCandidateMap.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 33 matching lines @@
 
 void CustomElementUpgradeCandidateMap::add(const CustomElementDescriptor& descriptor, Element* element)
 {
     observe(element);
 
     UpgradeCandidateMap::AddResult result = m_upgradeCandidates.add(element, descriptor);
     ASSERT_UNUSED(result, result.isNewEntry);
 
     UnresolvedDefinitionMap::iterator it = m_unresolvedDefinitions.find(descriptor);
     if (it == m_unresolvedDefinitions.end())
-        it = m_unresolvedDefinitions.add(descriptor, ElementSet()).iterator;
-    it->value.add(element);
+        m_unresolvedDefinitions.add(descriptor, ElementSet()).iterator->value.add(element);

[Inactive, 2014/02/04 14:21:33]

This sort of change leads to some code duplication.

+    else
+        it->value.add(element);
 }
 
 void CustomElementUpgradeCandidateMap::remove(Element* element)
 {
     unobserve(element);
     removeCommon(element);
 }
 
 void CustomElementUpgradeCandidateMap::elementWasDestroyed(Element* element)
 {
@@ skipping 35 matching lines @@
 
     for (ElementSet::const_iterator candidate = candidates.begin(); candidate != candidates.end(); ++candidate) {
         unobserve(*candidate);
         m_upgradeCandidates.remove(*candidate);
     }
 
     return candidates;
 }
 
 }