Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: src/full-codegen.cc

Issue 15288011: Baseline for-of implementation (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: s/syntax/semantics/ Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast.h ('k') | src/heap.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/full-codegen.cc
diff --git a/src/full-codegen.cc b/src/full-codegen.cc
index c32309a61f77b646d039dfc6cf490e16d761ad24..fe3c43f692086ec56d17b31570941467463a7076 100644
--- a/src/full-codegen.cc
+++ b/src/full-codegen.cc
@@ -164,8 +164,8 @@ void BreakableStatementChecker::VisitForInStatement(ForInStatement* stmt) {
void BreakableStatementChecker::VisitForOfStatement(ForOfStatement* stmt) {
- // Mark for in statements breakable if the iterable expression is.
- Visit(stmt->iterable());
+ // For-of is breakable because of the next() call.
+ is_breakable_ = true;
}
@@ -1389,11 +1389,6 @@ void FullCodeGenerator::VisitForStatement(ForStatement* stmt) {
}
-void FullCodeGenerator::VisitForOfStatement(ForOfStatement* stmt) {
- // TODO(wingo): Implement.
-}
-
-
void FullCodeGenerator::VisitTryCatchStatement(TryCatchStatement* stmt) {
Comment cmnt(masm_, "[ TryCatchStatement");
SetStatementPosition(stmt);
« no previous file with comments | « src/ast.h ('k') | src/heap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698