fpdfsdk/src/javascript/JS_Value.cpp - Issue 1528763003: Merge to XFA: Get rid of most instance of 'foo == NULL'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/javascript/JS_Value.cpp

Issue 1528763003: Merge to XFA: Get rid of most instance of 'foo == NULL' (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/javascript/JS_Value.cpp

diff --git a/fpdfsdk/src/javascript/JS_Value.cpp b/fpdfsdk/src/javascript/JS_Value.cpp

index a5844c1d58eba0407c92920c37a8e12cc990b9b1..ea7bfda57ad712bd81b710fbf18bcd4f6ccf724f 100644

--- a/fpdfsdk/src/javascript/JS_Value.cpp

+++ b/fpdfsdk/src/javascript/JS_Value.cpp

@@ -611,7 +611,7 @@ int _getDaylightSavingTA(double d) {

return 0;

time_t t = (time_t)(d / 1000);

struct tm* tmp = localtime(&t);

- if (tmp == NULL)

+ if (!tmp)

return 0;

if (tmp->tm_isdst > 0)

// One hour.