Merge to XFA: Get rid of most instance of 'foo == NULL'

fpdfsdk/src/fpdfview.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "public/fpdfview.h"
 
 #include "core/include/fxcodec/fx_codec.h"
 #include "core/include/fxcrt/fx_safe_types.h"
@@ skipping 470 matching lines @@
   if (!pDoc)
     return nullptr;
 
   if (page_index < 0 || page_index >= pDoc->GetPageCount())
     return nullptr;
 
 #ifdef PDF_ENABLE_XFA
   return pDoc->GetPage(page_index);
 #else   // PDF_ENABLE_XFA
   CPDF_Dictionary* pDict = pDoc->GetPage(page_index);
-  if (pDict == NULL)
+  if (!pDict)
     return NULL;
   CPDF_Page* pPage = new CPDF_Page;
   pPage->Load(pDoc, pDict);
   pPage->ParseContent();
   return pPage;
 #endif  // PDF_ENABLE_XFA
 }
 
 DLLEXPORT double STDCALL FPDF_GetPageWidth(FPDF_PAGE page) {
   UnderlyingPageType* pPage = UnderlyingFromFPDFPage(page);
@@ skipping 93 matching lines @@
   LPVOID pBuffer;
   BITMAPINFOHEADER bmih;
   FXSYS_memset(&bmih, 0, sizeof bmih);
   bmih.biSize = sizeof bmih;
   bmih.biBitCount = 24;
   bmih.biHeight = -height;
   bmih.biPlanes = 1;
   bmih.biWidth = width;
   pContext->m_hBitmap = CreateDIBSection(dc, (BITMAPINFO*)&bmih, DIB_RGB_COLORS,
                                          &pBuffer, NULL, 0);
-  if (pContext->m_hBitmap == NULL) {
+  if (!pContext->m_hBitmap) {
 #if defined(DEBUG) || defined(_DEBUG)
     char str[128];
     memset(str, 0, sizeof(str));
     FXSYS_snprintf(str, sizeof(str) - 1,
                    "Error CreateDIBSection: %d x %d, error code = %d", width,
                    height, GetLastError());
     CPDF_ModuleMgr::Get()->ReportError(FPDFERR_OUT_OF_MEMORY, str);
 #else
     CPDF_ModuleMgr::Get()->ReportError(FPDFERR_OUT_OF_MEMORY, NULL);
 #endif
@@ skipping 17 matching lines @@
   // output to bitmap device
   FPDF_RenderPage_Retail(pContext, page, start_x - rect.left,
                          start_y - rect.top, size_x, size_y, rotate, flags);
 
 #ifdef DEBUG_TRACE
   CPDF_ModuleMgr::Get()->ReportError(999, "Finished PDF rendering");
 #endif
 
   // Now output to real device
   HDC hMemDC = CreateCompatibleDC(dc);
-  if (hMemDC == NULL) {
+  if (!hMemDC) {
 #if defined(DEBUG) || defined(_DEBUG)
     char str[128];
     memset(str, 0, sizeof(str));
     FXSYS_snprintf(str, sizeof(str) - 1,
                    "Error CreateCompatibleDC. Error code = %d", GetLastError());
     CPDF_ModuleMgr::Get()->ReportError(FPDFERR_OUT_OF_MEMORY, str);
 #else
     CPDF_ModuleMgr::Get()->ReportError(FPDFERR_OUT_OF_MEMORY, NULL);
 #endif
   }
@@ skipping 102 matching lines @@
 DLLEXPORT void STDCALL FPDF_DeviceToPage(FPDF_PAGE page,
                                          int start_x,
                                          int start_y,
                                          int size_x,
                                          int size_y,
                                          int rotate,
                                          int device_x,
                                          int device_y,
                                          double* page_x,
                                          double* page_y) {
-  if (page == NULL || page_x == NULL || page_y == NULL)
+  if (!page || !page_x || !page_y)
     return;
   UnderlyingPageType* pPage = UnderlyingFromFPDFPage(page);
 #ifdef PDF_ENABLE_XFA
   pPage->DeviceToPage(start_x, start_y, size_x, size_y, rotate, device_x,
                       device_y, page_x, page_y);
 #else   // PDF_ENABLE_XFA
   CFX_Matrix page2device;
   pPage->GetDisplayMatrix(page2device, start_x, start_y, size_x, size_y,
                           rotate);
   CFX_Matrix device2page;
@@ skipping 72 matching lines @@
   pBitmap->Create(width, height, fx_format, (uint8_t*)first_scan, stride);
   return pBitmap;
 }
 
 DLLEXPORT void STDCALL FPDFBitmap_FillRect(FPDF_BITMAP bitmap,
                                            int left,
                                            int top,
                                            int width,
                                            int height,
                                            FPDF_DWORD color) {
-  if (bitmap == NULL)
+  if (!bitmap)
     return;
 #ifdef _SKIA_SUPPORT_
   CFX_SkiaDevice device;
 #else
   CFX_FxgeDevice device;
 #endif
   device.Attach((CFX_DIBitmap*)bitmap);
   if (!((CFX_DIBitmap*)bitmap)->HasAlpha())
     color |= 0xFF000000;
   FX_RECT rect(left, top, left + width, top + height);
   device.FillRect(&rect, color);
 }
 
 DLLEXPORT void* STDCALL FPDFBitmap_GetBuffer(FPDF_BITMAP bitmap) {
-  if (bitmap == NULL)
-    return NULL;
-  return ((CFX_DIBitmap*)bitmap)->GetBuffer();
+  return bitmap ? ((CFX_DIBitmap*)bitmap)->GetBuffer() : nullptr;
 }
 
 DLLEXPORT int STDCALL FPDFBitmap_GetWidth(FPDF_BITMAP bitmap) {
-  if (bitmap == NULL)
-    return 0;
-  return ((CFX_DIBitmap*)bitmap)->GetWidth();
+  return bitmap ? ((CFX_DIBitmap*)bitmap)->GetWidth() : 0;
 }
 
 DLLEXPORT int STDCALL FPDFBitmap_GetHeight(FPDF_BITMAP bitmap) {
-  if (bitmap == NULL)
-    return 0;
-  return ((CFX_DIBitmap*)bitmap)->GetHeight();
+  return bitmap ? ((CFX_DIBitmap*)bitmap)->GetHeight() : 0;
 }
 
 DLLEXPORT int STDCALL FPDFBitmap_GetStride(FPDF_BITMAP bitmap) {
-  if (bitmap == NULL)
-    return 0;
-  return ((CFX_DIBitmap*)bitmap)->GetPitch();
+  return bitmap ? ((CFX_DIBitmap*)bitmap)->GetPitch() : 0;
 }
 
 DLLEXPORT void STDCALL FPDFBitmap_Destroy(FPDF_BITMAP bitmap) {
   delete (CFX_DIBitmap*)bitmap;
 }
 
 void FPDF_RenderPage_Retail(CRenderContext* pContext,
                             FPDF_PAGE page,
                             int start_x,
                             int start_y,
@@ skipping 283 matching lines @@
   if (!buffer) {
     *buflen = len;
   } else if (*buflen >= len) {
     memcpy(buffer, utf16Name.c_str(), len);
     *buflen = len;
   } else {
     *buflen = -1;
   }
   return (FPDF_DEST)pDestObj;
 }