Merge to XFA: Get rid of most instance of 'foo == NULL'

core/src/fxge/ge/fx_ge_ps.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/include/fxge/fx_ge.h"
 #include "core/include/fxcodec/fx_codec.h"
 #include "text_int.h"
 
@@ skipping 356 matching lines @@
   if (pSource->IsAlphaMask() && (alpha < 255 || pSource->GetBPP() != 1)) {
     return FALSE;
   }
   OUTPUT_PS("q\n");
   CFX_ByteTextBuf buf;
   buf << "[" << pMatrix->a << " " << pMatrix->b << " " << pMatrix->c << " "
       << pMatrix->d << " " << pMatrix->e << " " << pMatrix->f << "]cm ";
   int width = pSource->GetWidth();
   int height = pSource->GetHeight();
   buf << width << " " << height;
-  if (pSource->GetBPP() == 1 && pSource->GetPalette() == NULL) {
+  if (pSource->GetBPP() == 1 && !pSource->GetPalette()) {
     int pitch = (width + 7) / 8;
     FX_DWORD src_size = height * pitch;
     uint8_t* src_buf = FX_Alloc(uint8_t, src_size);
     for (int row = 0; row < height; row++) {
       const uint8_t* src_scan = pSource->GetScanline(row);
       FXSYS_memcpy(src_buf + row * pitch, src_scan, pitch);
     }
     uint8_t* output_buf;
     FX_DWORD output_size;
     FaxCompressData(src_buf, width, height, output_buf, output_size);
@@ skipping 38 matching lines @@
           break;
         case FXDIB_8bppCmyk:
           if (pSource->GetPalette()) {
             pConverted = pSource->CloneConvert(FXDIB_Cmyk);
           }
           break;
         default:
           break;
       }
     }
-    if (pConverted == NULL) {
+    if (!pConverted) {
       OUTPUT_PS("\nQ\n");
       return FALSE;
     }
     int Bpp = pConverted->GetBPP() / 8;
     uint8_t* output_buf = NULL;
     FX_STRSIZE output_size = 0;
     const FX_CHAR* filter = NULL;
     if (flags & FXRENDER_IMAGE_LOSSY) {
       CCodec_ModuleMgr* pEncoders = CFX_GEModule::Get()->GetCodecModule();
       if (pEncoders &&
           pEncoders->GetJpegModule()->Encode(pConverted, output_buf,
                                              output_size)) {
         filter = "/DCTDecode filter ";
       }
     }
-    if (filter == NULL) {
+    if (!filter) {
       int src_pitch = width * Bpp;
       output_size = height * src_pitch;
       output_buf = FX_Alloc(uint8_t, output_size);
       for (int row = 0; row < height; row++) {
         const uint8_t* src_scan = pConverted->GetScanline(row);
         uint8_t* dest_scan = output_buf + row * src_pitch;
         if (Bpp == 3) {
           for (int col = 0; col < width; col++) {
             *dest_scan++ = src_scan[2];
             *dest_scan++ = src_scan[1];
@@ skipping 133 matching lines @@
         charpos.m_AdjustMatrix[3];
   }
   pPSFont->m_nGlyphs++;
   CFX_Matrix matrix;
   if (charpos.m_bGlyphAdjust)
     matrix.Set(charpos.m_AdjustMatrix[0], charpos.m_AdjustMatrix[1],
                charpos.m_AdjustMatrix[2], charpos.m_AdjustMatrix[3], 0, 0);
   matrix.Concat(1.0f, 0, 0, 1.0f, 0, 0);
   const CFX_PathData* pPathData = pFaceCache->LoadGlyphPath(
       pFont, charpos.m_GlyphIndex, charpos.m_FontCharWidth);
-  if (pPathData == NULL) {
+  if (!pPathData) {
     return;
   }
   CFX_PathData TransformedPath(*pPathData);
   if (charpos.m_bGlyphAdjust) {
     TransformedPath.Transform(&matrix);
   }
   CFX_ByteTextBuf buf;
   buf << "/X" << ps_fontnum << " Ff/CharProcs get begin/" << ps_glyphindex
       << "{n ";
   for (int p = 0; p < TransformedPath.GetPointCount(); p++) {
@@ skipping 39 matching lines @@
   }
   if ((pObject2Device->a == 0 && pObject2Device->b == 0) ||
       (pObject2Device->c == 0 && pObject2Device->d == 0)) {
     return TRUE;
   }
   SetColor(color, alpha_flag, pIccTransform);
   CFX_ByteTextBuf buf;
   buf << "q[" << pObject2Device->a << " " << pObject2Device->b << " "
       << pObject2Device->c << " " << pObject2Device->d << " "
       << pObject2Device->e << " " << pObject2Device->f << "]cm\n";
-  if (pCache == NULL) {
+  if (!pCache) {
     pCache = CFX_GEModule::Get()->GetFontCache();
   }
   CFX_FaceCache* pFaceCache = pCache->GetCachedFace(pFont);
   FX_FONTCACHE_DEFINE(pCache, pFont);
   int last_fontnum = -1;
   for (int i = 0; i < nChars; i++) {
     int ps_fontnum, ps_glyphindex;
     FindPSFontGlyph(pFaceCache, pFont, pCharPos[i], ps_fontnum, ps_glyphindex);
     if (last_fontnum != ps_fontnum) {
       buf << "/X" << ps_fontnum << " Ff " << font_size << " Fs Sf ";
@@ skipping 13 matching lines @@
   FX_DWORD dest_size;
   CCodec_ModuleMgr* pEncoders = CFX_GEModule::Get()->GetCodecModule();
   if (pEncoders &&
       pEncoders->GetBasicModule()->A85Encode(data, len, dest_buf, dest_size)) {
     m_pOutput->OutputPS((const FX_CHAR*)dest_buf, dest_size);
     FX_Free(dest_buf);
   } else {
     m_pOutput->OutputPS((const FX_CHAR*)data, len);
   }
 }