Merge to XFA: Get rid of most instance of 'foo == NULL'

core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/include/fpdfapi/fpdf_serial.h"
 
 CFDF_Document::CFDF_Document() : CPDF_IndirectObjects(NULL) {
   m_pRootDict = NULL;
@@ skipping 12 matching lines @@
   CPDF_Dictionary* pFDFDict = new CPDF_Dictionary;
   pDoc->m_pRootDict->SetAt("FDF", pFDFDict);
   return pDoc;
 }
 CFDF_Document* CFDF_Document::ParseFile(IFX_FileRead* pFile, FX_BOOL bOwnFile) {
   if (!pFile) {
     return NULL;
   }
   CFDF_Document* pDoc = new CFDF_Document;
   pDoc->ParseStream(pFile, bOwnFile);
-  if (pDoc->m_pRootDict == NULL) {
+  if (!pDoc->m_pRootDict) {
     delete pDoc;
     return NULL;
   }
   return pDoc;
 }
 CFDF_Document* CFDF_Document::ParseMemory(const uint8_t* pData, FX_DWORD size) {
   return CFDF_Document::ParseFile(FX_CreateMemoryStream((uint8_t*)pData, size),
                                   TRUE);
 }
 void CFDF_Document::ParseStream(IFX_FileRead* pFile, FX_BOOL bOwnFile) {
   m_pFile = pFile;
   m_bOwnFile = bOwnFile;
   CPDF_SyntaxParser parser;
   parser.InitParser(m_pFile, 0);
   while (1) {
     FX_BOOL bNumber;
     CFX_ByteString word = parser.GetNextWord(bNumber);
     if (bNumber) {
       FX_DWORD objnum = FXSYS_atoi(word);
       word = parser.GetNextWord(bNumber);
       if (!bNumber) {
         break;
       }
       word = parser.GetNextWord(bNumber);
       if (word != "obj") {
         break;
       }
       CPDF_Object* pObj = parser.GetObject(this, objnum, 0, 0);
-      if (pObj == NULL) {
+      if (!pObj) {
         break;
       }
       InsertIndirectObject(objnum, pObj);
       word = parser.GetNextWord(bNumber);
       if (word != "endobj") {
         break;
       }
     } else {
       if (word != "trailer") {
         break;
       }
       if (CPDF_Dictionary* pMainDict =
               ToDictionary(parser.GetObject(this, 0, 0, 0))) {
         m_pRootDict = pMainDict->GetDict("Root");
         pMainDict->Release();
       }
       break;
     }
   }
 }
 FX_BOOL CFDF_Document::WriteBuf(CFX_ByteTextBuf& buf) const {
-  if (m_pRootDict == NULL) {
+  if (!m_pRootDict) {
     return FALSE;
   }
   buf << "%FDF-1.2\r\n";
   FX_POSITION pos = m_IndirectObjs.GetStartPosition();
   while (pos) {
     size_t objnum;
     CPDF_Object* pObj;
     m_IndirectObjs.GetNextAssoc(pos, (void*&)objnum, (void*&)pObj);
     buf << (FX_DWORD)objnum << " 0 obj\r\n" << pObj << "\r\nendobj\r\n\r\n";
   }
@@ skipping 75 matching lines @@
     result += wsFileName[1];
     result += ':';
     result += ChangeSlash(wsFileName.c_str() + 2);
     return result;
   }
   CFX_WideString result;
   result += '\\';
   result += ChangeSlash(wsFileName.c_str());
   return result;
 }