third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html - Issue 1528713002: Update MSE Android layout test expectations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html

Issue 1528713002: Update MSE Android layout test expectations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer-expected.txt » ('j') | third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer-expected.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html b/third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html

index 1a11f5ccde43ce4e0be59234182492323f377c4d..2386c523e02aa6e62df138a1123b76dd894b4adc 100644

--- a/third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html

+++ b/third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html

@@ -10,6 +10,12 @@

<body>

+ // TODO(wolenetz): Remove this hacky console warning once desktop and

+ // android expectations match. It allows a passing platform-specific

+ // expectation to override a failing non-platform-specific expectation.

+ // See https://crbug.com/568704.

ddorwin 2015/12/15 01:33:32 The bug doesn't explain why we need this warning.

wolenetz 2015/12/15 20:07:20 Bug updated. Bug link portion of comment moved to

+ console.warn('Ignore this warning.');

mediasource_test(function(test, mediaElement, mediaSource)

{

mediaSource.endOfStream();