Update MSE Android layout test expectations

Update MSE Android layout test expectations

With Spitzer, more of the MSE layout tests now pass (when run locally on
a build with proprietary codecs). To ease local Spitzer testing, this
change updates expectations to assume proprietary codecs are being
tested on Spitzer, including some new failures.  Note that none of these
updated layout tests are currently executed on Android bots. See bug
568704, which would make much of the platform/android portion of this
change redundant if fixed, because similar would be needed for
non-Android builds.

BUG=568704, 302729, 568867, 555703
R=chcunningham@chromium.org,mlamouri@chromium.org

Committed: https://crrev.com/afc6c777ae3655d9a0267784eafd72b473d7295b
Cr-Commit-Position: refs/heads/master@{#365366}

[wolenetz, 2015-12-14 22:40:33]

Description was changed from

==========
Update MSE Android layout test expectations

With Spitzer, more of the MSE layout tests now pass (when run locally on
a build with proprietary codecs). To ease local Spitzer testing, this
change updates expectations to assume proprietary codecs are being
tested on Spitzer, including some new failures.  Note that none of these
updated layout tests are currently executed on Android bots. See bug
568704, which would make much of the platform/android portion of this
change redundant if fixed, because similar would be needed for
non-Android builds.

BUG=568704,302729,568867,555703
R=chcunningham@chromium.org,mlamouri@chromium.org
==========

to

==========
Update MSE Android layout test expectations

With Spitzer, more of the MSE layout tests now pass (when run locally on
a build with proprietary codecs). To ease local Spitzer testing, this
change updates expectations to assume proprietary codecs are being
tested on Spitzer, including some new failures.  Note that none of these
updated layout tests are currently executed on Android bots. See bug
568704, which would make much of the platform/android portion of this
change redundant if fixed, because similar would be needed for
non-Android builds.

BUG=568704,302729,568867,555703
R=chcunningham@chromium.org,mlamouri@chromium.org
==========

[wolenetz, 2015-12-14 22:40:33]

wolenetz@chromium.org changed reviewers:
- mlamouri@chromium.org

[wolenetz, 2015-12-14 22:46:09]

cc+ mlamouri@ (w.r.t. using the suggested hack to pass presubmit when
platform-specific "pass" overrides general "fail".
cc+ dalecurtis@ (w.r.t. Spitzer)

chcunningham@, please review patch set 1:

This CL introduces Android platform-specific MSE layout test expectations for
what is expected currently on Android (with proprietary codecs).
Note again: None of these
updated layout tests are currently executed on Android bots.
The top-level TestExpectations file is also adjusted relative to current
Android-with-Spitzer actual observed failures/passes relative to the newly added
platform-specific *-expected.txt files.

[chcunningham, 2015-12-15 00:46:09]

lgtm

[wolenetz, 2015-12-15 01:12:39]

The CQ bit was checked by wolenetz@chromium.org

[commit-bot: I haz the power, 2015-12-15 01:17:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1528713002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1528713002/1

[ddorwin, 2015-12-15 01:33:32]

ddorwin@chromium.org changed reviewers:
+ ddorwin@chromium.org

[ddorwin, 2015-12-15 01:33:32]

https://codereview.chromium.org/1528713002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer-expected.txt
(right):

https://codereview.chromium.org/1528713002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer-expected.txt:1:
CONSOLE WARNING: line 17: Ignore this warning.
Add the bug entry so readers don't have to dig.

https://codereview.chromium.org/1528713002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html
(right):

https://codereview.chromium.org/1528713002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html:16:
// See https://crbug.com/568704.
The bug doesn't explain why we need this warning.

[wolenetz, 2015-12-15 03:03:11]

The CQ bit was unchecked by wolenetz@chromium.org

[wolenetz, 2015-12-15 03:07:45]

On 2015/12/15 01:33:32, ddorwin wrote:
>
https://codereview.chromium.org/1528713002/diff/1/third_party/WebKit/LayoutTe...
> File
>
third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer-expected.txt
> (right):
> 
>
https://codereview.chromium.org/1528713002/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer-expected.txt:1:
> CONSOLE WARNING: line 17: Ignore this warning.
> Add the bug entry so readers don't have to dig.
> 
>
https://codereview.chromium.org/1528713002/diff/1/third_party/WebKit/LayoutTe...
> File
>
third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html
> (right):
> 
>
https://codereview.chromium.org/1528713002/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html:16:
> // See https://crbug.com/568704.
> The bug doesn't explain why we need this warning.

Good points, ddorwin@. I'll fix these when back at keyboard in the morning. I'm
afk atm; CQ bit unchecked.

[wolenetz, 2015-12-15 20:07:20]

ddorwin@: Please review patch set 2 (it's a rebase + response to your PS1
comments).

https://codereview.chromium.org/1528713002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer-expected.txt
(right):

https://codereview.chromium.org/1528713002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer-expected.txt:1:
CONSOLE WARNING: line 17: Ignore this warning.
On 2015/12/15 01:33:32, ddorwin wrote:
> Add the bug entry so readers don't have to dig.

Done.

https://codereview.chromium.org/1528713002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html
(right):

https://codereview.chromium.org/1528713002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html:16:
// See https://crbug.com/568704.
On 2015/12/15 01:33:32, ddorwin wrote:
> The bug doesn't explain why we need this warning.

Bug updated. Bug link portion of comment moved to the warning message, with link
to specific explanatory comment in the bug.

[wolenetz, 2015-12-15 20:07:39]

The CQ bit was checked by wolenetz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-15 20:09:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1528713002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1528713002/20001

[commit-bot: I haz the power, 2015-12-15 21:18:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-15 21:18:11]

Dry run: This issue passed the CQ dry run.

[ddorwin, 2015-12-15 22:00:15]

My issues LG (with one observation). You might add that observation about the
workaround to the new bug too.

https://codereview.chromium.org/1528713002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/platform/android/http/tests/media/media-source/mediasource-addsourcebuffer-expected.txt
(right):

https://codereview.chromium.org/1528713002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/platform/android/http/tests/media/media-source/mediasource-addsourcebuffer-expected.txt:1:
CONSOLE WARNING: line 16: Ignore this warning. See https://crbug.com/568704#c2
Unfortunately, the line number means any code change could cause the expectation
to need to be updated. :(

[wolenetz, 2015-12-15 22:08:53]

On 2015/12/15 22:00:15, ddorwin wrote:
> My issues LG (with one observation). You might add that observation about the
> workaround to the new bug too.
> 
>
https://codereview.chromium.org/1528713002/diff/20001/third_party/WebKit/Layo...
> File
>
third_party/WebKit/LayoutTests/platform/android/http/tests/media/media-source/mediasource-addsourcebuffer-expected.txt
> (right):
> 
>
https://codereview.chromium.org/1528713002/diff/20001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/platform/android/http/tests/media/media-source/mediasource-addsourcebuffer-expected.txt:1:
> CONSOLE WARNING: line 16: Ignore this warning. See https://crbug.com/568704#c2
> Unfortunately, the line number means any code change could cause the
expectation
> to need to be updated. :(

Done (in https://code.google.com/p/chromium/issues/detail?id=570044#c1)

Thanks for the quality CR, everyone. I'll send to CQ shortly.

[wolenetz, 2015-12-15 22:14:20]

The CQ bit was checked by wolenetz@chromium.org

[wolenetz, 2015-12-15 22:14:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
chcunningham@chromium.org
Link to the patchset: https://codereview.chromium.org/1528713002/#ps20001
(title: "Address ddorwin@'s comments")

[commit-bot: I haz the power, 2015-12-15 22:15:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1528713002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1528713002/20001

[commit-bot: I haz the power, 2015-12-15 22:46:44]

Description was changed from

==========
Update MSE Android layout test expectations

With Spitzer, more of the MSE layout tests now pass (when run locally on
a build with proprietary codecs). To ease local Spitzer testing, this
change updates expectations to assume proprietary codecs are being
tested on Spitzer, including some new failures.  Note that none of these
updated layout tests are currently executed on Android bots. See bug
568704, which would make much of the platform/android portion of this
change redundant if fixed, because similar would be needed for
non-Android builds.

BUG=568704,302729,568867,555703
R=chcunningham@chromium.org,mlamouri@chromium.org
==========

to

==========
Update MSE Android layout test expectations

With Spitzer, more of the MSE layout tests now pass (when run locally on
a build with proprietary codecs). To ease local Spitzer testing, this
change updates expectations to assume proprietary codecs are being
tested on Spitzer, including some new failures.  Note that none of these
updated layout tests are currently executed on Android bots. See bug
568704, which would make much of the platform/android portion of this
change redundant if fixed, because similar would be needed for
non-Android builds.

BUG=568704,302729,568867,555703
R=chcunningham@chromium.org,mlamouri@chromium.org
==========

[commit-bot: I haz the power, 2015-12-15 22:46:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-15 22:47:24]

Description was changed from

==========
Update MSE Android layout test expectations

With Spitzer, more of the MSE layout tests now pass (when run locally on
a build with proprietary codecs). To ease local Spitzer testing, this
change updates expectations to assume proprietary codecs are being
tested on Spitzer, including some new failures.  Note that none of these
updated layout tests are currently executed on Android bots. See bug
568704, which would make much of the platform/android portion of this
change redundant if fixed, because similar would be needed for
non-Android builds.

BUG=568704,302729,568867,555703
R=chcunningham@chromium.org,mlamouri@chromium.org
==========

to

==========
Update MSE Android layout test expectations

With Spitzer, more of the MSE layout tests now pass (when run locally on
a build with proprietary codecs). To ease local Spitzer testing, this
change updates expectations to assume proprietary codecs are being
tested on Spitzer, including some new failures.  Note that none of these
updated layout tests are currently executed on Android bots. See bug
568704, which would make much of the platform/android portion of this
change redundant if fixed, because similar would be needed for
non-Android builds.

BUG=568704,302729,568867,555703
R=chcunningham@chromium.org,mlamouri@chromium.org

Committed: https://crrev.com/afc6c777ae3655d9a0267784eafd72b473d7295b
Cr-Commit-Position: refs/heads/master@{#365366}
==========

[commit-bot: I haz the power, 2015-12-15 22:47:25]

Patchset 2 (id:??) landed as
https://crrev.com/afc6c777ae3655d9a0267784eafd72b473d7295b
Cr-Commit-Position: refs/heads/master@{#365366}