Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1528643004: [turbofan] Fix RawMachineAssembler for multiple return values. (Closed)

Created:
5 years ago by Michael Starzinger
Modified:
5 years ago
Reviewers:
mythria
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix RawMachineAssembler for multiple return values. This fixes runtime calls emitted by the RawMachineAssembler to use the correct CEntryStub depending on the return count of runtime functions. Note that this only affects WIN64 and PPC, where the ABI is different. R=mythria@chromium.org Committed: https://crrev.com/1362f935ad212d12196ce7866d389d569ef21259 Cr-Commit-Position: refs/heads/master@{#32864}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M src/compiler/raw-machine-assembler.cc View 5 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years ago (2015-12-15 12:15:49 UTC) #1
mythria
lgtm
5 years ago (2015-12-15 12:28:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528643004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528643004/1
5 years ago (2015-12-15 13:23:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 13:24:21 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-15 13:24:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1362f935ad212d12196ce7866d389d569ef21259
Cr-Commit-Position: refs/heads/master@{#32864}

Powered by Google App Engine
This is Rietveld 408576698