Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: src/accessors.cc

Issue 152863002: Use Type* in crankshaft rather than HeapType. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/accessors.cc
diff --git a/src/accessors.cc b/src/accessors.cc
index 25ee3059abe33118daf39b24768b0f25582e21d5..264081c59d85e009c3d032331b1e0dc047d63e0c 100644
--- a/src/accessors.cc
+++ b/src/accessors.cc
@@ -79,64 +79,6 @@ MaybeObject* Accessors::ReadOnlySetAccessor(Isolate* isolate,
}
-static V8_INLINE bool CheckForName(Handle<String> name,
- String* property_name,
- int offset,
- int* object_offset) {
- if (name->Equals(property_name)) {
- *object_offset = offset;
- return true;
- }
- return false;
-}
-
-
-bool Accessors::IsJSObjectFieldAccessor(Handle<HeapType> type,
- Handle<String> name,
- int* object_offset) {
- Isolate* isolate = name->GetIsolate();
-
- if (type->Is(HeapType::String())) {
- return CheckForName(name, isolate->heap()->length_string(),
- String::kLengthOffset, object_offset);
- }
-
- if (!type->IsClass()) return false;
- Handle<Map> map = type->AsClass();
-
- switch (map->instance_type()) {
- case JS_ARRAY_TYPE:
- return
- CheckForName(name, isolate->heap()->length_string(),
- JSArray::kLengthOffset, object_offset);
- case JS_TYPED_ARRAY_TYPE:
- return
- CheckForName(name, isolate->heap()->length_string(),
- JSTypedArray::kLengthOffset, object_offset) ||
- CheckForName(name, isolate->heap()->byte_length_string(),
- JSTypedArray::kByteLengthOffset, object_offset) ||
- CheckForName(name, isolate->heap()->byte_offset_string(),
- JSTypedArray::kByteOffsetOffset, object_offset) ||
- CheckForName(name, isolate->heap()->buffer_string(),
- JSTypedArray::kBufferOffset, object_offset);
- case JS_ARRAY_BUFFER_TYPE:
- return
- CheckForName(name, isolate->heap()->byte_length_string(),
- JSArrayBuffer::kByteLengthOffset, object_offset);
- case JS_DATA_VIEW_TYPE:
- return
- CheckForName(name, isolate->heap()->byte_length_string(),
- JSDataView::kByteLengthOffset, object_offset) ||
- CheckForName(name, isolate->heap()->byte_offset_string(),
- JSDataView::kByteOffsetOffset, object_offset) ||
- CheckForName(name, isolate->heap()->buffer_string(),
- JSDataView::kBufferOffset, object_offset);
- default:
- return false;
- }
-}
-
-
//
// Accessors::ArrayLength
//

Powered by Google App Engine
This is Rietveld 408576698