Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 152863002: Use Type* in crankshaft rather than HeapType. (Closed)

Created:
6 years, 10 months ago by Toon Verwaest
Modified:
6 years, 10 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Use Type* in crankshaft rather than HeapType. R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19069

Patch Set 1 : #

Total comments: 3

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -87 lines) Patch
M src/accessors.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M src/accessors.cc View 1 2 chunks +17 lines, -2 lines 0 comments Download
M src/hydrogen.h View 7 chunks +12 lines, -9 lines 0 comments Download
M src/hydrogen.cc View 30 chunks +66 lines, -62 lines 0 comments Download
M src/ic.h View 1 1 chunk +6 lines, -3 lines 0 comments Download
M src/ic.cc View 1 3 chunks +20 lines, -8 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Toon Verwaest
PTAL
6 years, 10 months ago (2014-02-03 15:52:04 UTC) #1
rossberg
https://codereview.chromium.org/152863002/diff/30001/src/accessors.h File src/accessors.h (right): https://codereview.chromium.org/152863002/diff/30001/src/accessors.h#newcode103 src/accessors.h:103: template <class T> You don't necessarily need to move ...
6 years, 10 months ago (2014-02-03 16:54:05 UTC) #2
Toon Verwaest
Addressed comments, ptal again
6 years, 10 months ago (2014-02-04 09:24:19 UTC) #3
rossberg
lgtm
6 years, 10 months ago (2014-02-04 12:23:00 UTC) #4
Toon Verwaest
6 years, 10 months ago (2014-02-04 12:44:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r19069 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698