Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.h

Issue 1528543004: Update chooser bubble ui cocoa code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@modify_base_bubble_controller_dealloc
Patch Set: updated chooser bubble ui cocoa code based on rsesek@'s comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.h
diff --git a/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.h b/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.h
index 8be15bd977fa77ae4e82b327fc34fbe186c55a4f..d765eabe1a7da2f51800fda9ebd6cfaf6d704b3c 100644
--- a/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.h
+++ b/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.h
@@ -22,7 +22,7 @@ class ChooserBubbleUiCocoa : public BubbleUi,
public ChooserBubbleDelegate::Observer {
public:
ChooserBubbleUiCocoa(Browser* browser,
- ChooserBubbleDelegate* chooser_bubble_delegate);
+ ChooserBubbleDelegate* chooserBubbleDelegate);
~ChooserBubbleUiCocoa() override;
// BubbleUi:
@@ -40,9 +40,9 @@ class ChooserBubbleUiCocoa : public BubbleUi,
private:
Browser* browser_; // Weak.
- ChooserBubbleDelegate* chooser_bubble_delegate_; // Weak.
+ ChooserBubbleDelegate* chooserBubbleDelegate_; // Weak.
Robert Sesek 2015/12/15 15:17:38 The naming here is correct. In ObjC methods and @i
juncai 2015/12/15 18:01:11 Done.
// Cocoa-side chooser bubble UI controller. Weak, as it will close itself.
- ChooserBubbleUiController* chooser_bubble_ui_controller_;
+ ChooserBubbleUiController* chooserBubbleUiController_;
DISALLOW_COPY_AND_ASSIGN(ChooserBubbleUiCocoa);
};
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698