Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Unified Diff: components/variations/variations_http_header_provider.h

Issue 1528543003: Implement plumbing for variations in feedback reports. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Re-add function that was lost in a rebase. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/variations/variations_http_header_provider.h
diff --git a/components/variations/variations_http_header_provider.h b/components/variations/variations_http_header_provider.h
index 18ff19d305efeff2841dc23818c6b140bed2409a..3c6ce75d0deb3739e63f1813421ca9cca9258632 100644
--- a/components/variations/variations_http_header_provider.h
+++ b/components/variations/variations_http_header_provider.h
@@ -35,6 +35,12 @@ class VariationsHttpHeaderProvider : public base::FieldTrialList::Observer,
// necessary.
std::string GetClientDataHeader();
+ // Returns a space-separated string containing the list of current active
+ // variations (as would be reported in the |variation_id| repeated field of
+ // the ClientVariations proto). The returned string is guaranteed to have a
+ // a leading and trailing space, e.g. " 123 234 345 ".
+ std::string GetVariationsString();
+
// Sets *additional* variation ids and trigger variation ids to be encoded in
// the X-Client-Data request header. This is intended for development use to
// force a server side experiment id. |variation_ids| should be a
@@ -54,6 +60,8 @@ class VariationsHttpHeaderProvider : public base::FieldTrialList::Observer,
SetDefaultVariationIds_Invalid);
FRIEND_TEST_ALL_PREFIXES(VariationsHttpHeaderProviderTest,
OnFieldTrialGroupFinalized);
+ FRIEND_TEST_ALL_PREFIXES(VariationsHttpHeaderProviderTest,
+ GetVariationsString);
VariationsHttpHeaderProvider();
~VariationsHttpHeaderProvider() override;
@@ -78,6 +86,10 @@ class VariationsHttpHeaderProvider : public base::FieldTrialList::Observer,
// held.
void UpdateVariationIDsHeaderValue();
+ // Returns the currently active set of variation ids, which includes any
+ // default values, synthetic variations and actual field trial variations.
+ std::set<VariationID> GetAllVariationIds();
+
// Guards |variation_ids_cache_initialized_|, |variation_ids_set_| and
// |variation_ids_header_|.
base::Lock lock_;

Powered by Google App Engine
This is Rietveld 408576698