chromecast/BUILD.gn - Issue 1528533002: [Chromecast] Replace architecure-based conditionals with flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/BUILD.gn

Issue 1528533002: [Chromecast] Replace architecure-based conditionals with flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Correct declare_args bug. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromecast/BUILD.gn

diff --git a/chromecast/BUILD.gn b/chromecast/BUILD.gn

index bc1a8a019c6145741d9241193f611eafcd093e48..4a93980485ea18c7d03b74f8d9f1a3e7186f3bfc 100644

--- a/chromecast/BUILD.gn

+++ b/chromecast/BUILD.gn

@@ -50,7 +50,8 @@ cast_test_group("cast_tests") {

filters = []

- if (target_cpu == "arm" && target_os == "linux") {

+ # Apply filters to embedded linux devices.

+ if (target_os == "linux" && !is_cast_desktop_build) {

filters += [

# Run net_unittests first to avoid random failures due to slow python startup

# KeygenHandlerTest.SmokeTest and KeygenHandlerTest.ConcurrencyTest fail due to

@@ -94,7 +95,7 @@ cast_test_group("cast_tests") {

# DoAppendUTF8Invalid fails because of dcheck_always_on flag in Eng builds

"url_unittests --gtest_filter=-URLCanonTest.DoAppendUTF8Invalid",

]

- } else if (target_cpu != "arm" || target_os == "android") {

+ } else if (is_cast_desktop_build || target_os == "android") {

byungchul 2015/12/15 23:14:17 It can be just "else".

slan 2015/12/16 02:48:00 This was done to be explicit about the condition:

filters += [

# Disable PipelineIntegrationTest.BasicPlayback_MediaSource_VP9_WebM (not supported)

"media_unittests --gtest_filter=-PipelineIntegrationTest.BasicPlayback_MediaSource_VP9_WebM",

« no previous file with comments | « build/config/chromecast_build.gni ('k') | chromecast/chromecast.gni » ('j') | no next file with comments »