Issue 152853006: Unify PreParser::ParseIdentifierName and Parser::ParseIdentifierName.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 152853006: Unify PreParser::ParseIdentifierName and Parser::ParseIdentifierName. (Closed)

Created:
6 years, 10 months ago by marja

Modified:
6 years, 10 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Unify PreParser::ParseIdentifierName and Parser::ParseIdentifierName. No special handling for keywords is needed, since the literal ascii strings for them work too (see how Parser did it). BUG=3126 LOG=N R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19184

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -11 lines)			Patch
	M	src/preparser.cc	View		1 chunk	+7 lines, -11 lines	0 comments	Download
	M	test/cctest/test-parsing.cc	View		1 chunk	+43 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

marja

6 years, 10 months ago (2014-02-07 08:45:38 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r19184 (presubmit successful).