Issue 1528523002: Finalizing an upper bound during a compile-time type test may lead to cycles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1528523002: Finalizing an upper bound during a compile-time type test may lead to cycles. (Closed)

Created:
5 years ago by regis

Modified:
5 years ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Finalizing an upper bound during a compile-time type test may lead to cycles. Fail the test instead, requiring a runtime test. This was introduced last week as https://codereview.chromium.org/1513493002/ in order to fix #25122. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/1c7f0a4d60e5ed7343273db59d70942c41db0852

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -7 lines)			Patch
	M	runtime/vm/object.cc	View		1 chunk	+3 lines, -7 lines	0 comments	Download

Total messages: 5 (2 generated)

regis

5 years ago (2015-12-14 19:38:23 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1c7f0a4d60e5ed7343273db59d70942c41db0852 (presubmit successful).