chrome/browser/extensions/BUILD.gn - Issue 1528483002: Add chrome.input.ime.activate and chrome.input.ime.deactivate API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/BUILD.gn

Issue 1528483002: Add chrome.input.ime.activate and chrome.input.ime.deactivate API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Devlin's comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.h » ('j') | chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/BUILD.gn

diff --git a/chrome/browser/extensions/BUILD.gn b/chrome/browser/extensions/BUILD.gn

index f7f94d409330f18479f6c28bd319bb66b0ef1e83..2ab2fe97af659b6b1943d5d5be640bc5c02c9399 100644

--- a/chrome/browser/extensions/BUILD.gn

+++ b/chrome/browser/extensions/BUILD.gn

@@ -155,6 +155,7 @@ source_set("extensions") {

gypi_values.chrome_browser_extensions_input_ime_linux_win_sources,

".",

"//chrome")

+ deps += [ "//ui/events:dom_keycode_converter" ]

}

@@ -210,6 +211,12 @@ source_set("extensions") {

gypi_values.chrome_browser_extensions_input_ime_linux_win_sources,

".",

"//chrome")

+ if (is_component_build) {

+ sources += [

+ "//ui/base/ime/ime_engine_handler_interface.cc",

+ "//ui/base/ime/ime_engine_handler_interface.h",

+ ]

+ }

} else if (use_aura && !is_chromeos) {

sources += [

"display_info_provider_aura.cc",