content/renderer/media/webrtc_audio_device_impl.h - Issue 1528473003: Feed the WebRTC APM with empty far-end frames for the number of frames skipped by OS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc_audio_device_impl.h

Issue 1528473003: Feed the WebRTC APM with empty far-end frames for the number of frames skipped by OS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review. Rebase. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/media_stream_audio_processor_unittest.cc ('k') | content/renderer/media/webrtc_audio_device_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc_audio_device_impl.h

diff --git a/content/renderer/media/webrtc_audio_device_impl.h b/content/renderer/media/webrtc_audio_device_impl.h

index e9e9d85672222aa7144831112d997a513a33b719..c7c2ff108b23f9be67b0e9faa5cf5e7433abf4c7 100644

--- a/content/renderer/media/webrtc_audio_device_impl.h

+++ b/content/renderer/media/webrtc_audio_device_impl.h

@@ -192,6 +192,7 @@ class WebRtcAudioRendererSource {

virtual void RenderData(media::AudioBus* audio_bus,

int sample_rate,

int audio_delay_milliseconds,

+ uint32_t skipped_frames,

base::TimeDelta* current_time) = 0;

// Callback to notify the client that the renderer is going away.

@@ -218,7 +219,8 @@ class WebRtcPlayoutDataSource {

// Called on the render audio thread.

virtual void OnPlayoutData(media::AudioBus* audio_bus,

int sample_rate,

- int audio_delay_milliseconds) = 0;

+ int audio_delay_milliseconds,

+ uint32_t skipped_frames) = 0;

// Callback to notify the sink that the source has changed.

// Called on the main render thread.

@@ -342,6 +344,7 @@ class CONTENT_EXPORT WebRtcAudioDeviceImpl

void RenderData(media::AudioBus* audio_bus,

int sample_rate,

int audio_delay_milliseconds,

+ uint32_t skipped_frames,

base::TimeDelta* current_time) override;

// Called on the main render thread.