Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 1528443003: Remove xkbcommon support. (Closed)

Created:
5 years ago by viettrungluu
Modified:
5 years ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove xkbcommon support. (This further reduces our use of pkg_config() in build files.) R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/04de9cefc981940f9298f896ffe42922a90065f4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -59 lines) Patch
M ui/events/BUILD.gn View 3 chunks +2 lines, -3 lines 0 comments Download
M ui/events/ozone/BUILD.gn View 3 chunks +0 lines, -16 lines 0 comments Download
D ui/events/xkb.gni View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/ozone/platform/drm/ozone_platform_drm.cc View 4 chunks +1 line, -16 lines 0 comments Download
M ui/ozone/platform/drm/ozone_platform_gbm.cc View 4 chunks +1 line, -16 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
5 years ago (2015-12-14 18:19:21 UTC) #1
jamesr
But mah dvorak!
5 years ago (2015-12-14 19:36:06 UTC) #2
jamesr
lgtm
5 years ago (2015-12-14 19:36:28 UTC) #3
viettrungluu
Committed patchset #1 (id:1) manually as 04de9cefc981940f9298f896ffe42922a90065f4 (presubmit successful).
5 years ago (2015-12-14 20:22:56 UTC) #5
kulakowski1
5 years ago (2015-12-14 20:51:12 UTC) #6
Message was sent while issue was closed.
On 2015/12/14 19:36:06, jamesr wrote:
> But mah dvorak!

I'll do it in hardware!

Powered by Google App Engine
This is Rietveld 408576698