Move BookmarkBubble with anchor

ui/views/bubble/bubble_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/bubble/bubble_delegate.h"
 
 #include "ui/base/accessibility/accessible_view_state.h"
 #include "ui/gfx/animation/slide_animation.h"
 #include "ui/gfx/color_utils.h"
 #include "ui/gfx/rect.h"
@@ skipping 158 matching lines @@
 
 void BubbleDelegateView::OnWidgetActivationChanged(Widget* widget,
                                                    bool active) {
   if (close_on_deactivate() && widget == GetWidget() && !active)
     GetWidget()->Close();
 }
 
 void BubbleDelegateView::OnWidgetBoundsChanged(Widget* widget,
                                                const gfx::Rect& new_bounds) {
   if (anchor_widget() == widget) {
-    if (move_with_anchor())
+    if (move_with_anchor()) {
       SizeToContents();
-    else
-      GetWidget()->Close();
+    } else {
+      // Do not close if the widget gets shrinked vertically without move.

[msw, 2014/02/13 00:32:48]

This seems odd, and I don't think this is the right fix. The widget bounds may
have the same origin and height, but the anchor bounds within that widget still
may have changed (the anchor view may have moved within the bounds of the
widget, due to layout changes). I think we could probably just close if the
widget origin changes, or the anchor bounds have changed; that should solve your
bug. LMK if you need help.

[oshima, 2014/02/13 01:28:29]

You're right that anchor position may change even if only the height changes,
but for the same reason, we need to close when the width changes because the
location of star icon does change when width changes.

I actually wonder why bookmark bubble isn't set to move with anchor. Do you know
why?

[msw, 2014/02/13 01:38:07]

I don't see a reason offhand why the bookmark bubble doesn't move with its
anchor (just tried this and it doesn't seem too broken). If that fixes your
issue and doesn't cause other issues, let's go with that.

+      gfx::Rect bounds = widget->GetWindowBoundsInScreen();
+      if (bounds.origin() != new_bounds.origin() ||
+          bounds.width() != new_bounds.width()) {
+        GetWidget()->Close();
+      }
+    }
   }
 }
 
 View* BubbleDelegateView::GetAnchorView() const {
   return ViewStorage::GetInstance()->RetrieveView(anchor_view_storage_id_);
 }
 
 gfx::Rect BubbleDelegateView::GetAnchorRect() {
   if (!GetAnchorView())
     return anchor_rect_;
@@ skipping 149 matching lines @@
 }
 
 void BubbleDelegateView::HandleVisibilityChanged(Widget* widget, bool visible) {
   if (widget == GetWidget() && visible && anchor_widget() &&
       anchor_widget()->GetTopLevelWidget()) {
     anchor_widget()->GetTopLevelWidget()->DisableInactiveRendering();
   }
 }
 
 }  // namespace views