Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 1528423002: Stage Proxies and Reflect behind --harmony flag (Closed)

Created:
5 years ago by Jakob Kummerow
Modified:
5 years ago
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Stage Proxies and Reflect behind --harmony flag BUG=v8:1543, v8:3931 LOG=y Committed: https://crrev.com/d30693880c833e1d504e296aeca2260924cf6b1c Cr-Commit-Position: refs/heads/master@{#32967}

Patch Set 1 #

Patch Set 2 : update test262 expectations #

Patch Set 3 : skip some tests for ignition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -21 lines) Patch
M src/flag-definitions.h View 2 chunks +2 lines, -4 lines 0 comments Download
M test/test262/test262.status View 1 2 4 chunks +10 lines, -17 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
Jakob Kummerow
5 years ago (2015-12-16 17:13:25 UTC) #2
Camillo Bruni
lgtm
5 years ago (2015-12-16 17:25:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528423002/1
5 years ago (2015-12-16 17:26:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/10108)
5 years ago (2015-12-16 17:41:54 UTC) #7
Dan Ehrenberg
Actually, let's not do this yet. We still haven't worked out the proxy security issue. ...
5 years ago (2015-12-16 17:51:55 UTC) #8
Toon Verwaest
What about just throwing e.g., a type error on contextual reads that end up trying ...
5 years ago (2015-12-16 19:36:14 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528423002/20001
5 years ago (2015-12-17 13:38:20 UTC) #12
Jakob Kummerow
Updated test262 expectations. Waiting for Dan's opinion on https://codereview.chromium.org/1529303003/ to unblock this.
5 years ago (2015-12-17 13:40:59 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/12281)
5 years ago (2015-12-17 14:02:31 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528423002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528423002/40001
5 years ago (2015-12-18 10:34:12 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-18 11:11:50 UTC) #19
commit-bot: I haz the power
5 years ago (2015-12-18 11:12:11 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d30693880c833e1d504e296aeca2260924cf6b1c
Cr-Commit-Position: refs/heads/master@{#32967}

Powered by Google App Engine
This is Rietveld 408576698